306711 - local favicons (specified in <link>) not used

Status: VERIFIED WONTFIX

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Ulrik Sverdrup]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050829 Camino/0.9a2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050829 Camino/0.9a2+

Camino does not use a local favicon specified in a web page with <link
rel="icon" href="image url"> when viewing a local page.

Reproducible: Always

Steps to Reproduce:
1. Build a web page that references a favicon
2. Display the page locally (not from local web server, from the filesystem 

Actual Results:  
The generic file icon is used

Expected Results:  
The specified icon should be used

If viewing a local page, but references a favicon from the web, camino performs
correctly (displays the favicon)

This is not a cross-browser issue. Firefox displays the local favicon.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yep.  Might be annoying for webdevs, esp. with the inconsistency described in
the next-to-last pgh of comment 0.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Hmm, I wonder if this might be the problem :P 

http://lxr.mozilla.org/mozilla/source/camino/src/embedding/CHBrowserListener.mm#841

841   // only accept http and https icons (should we allow https, even?)
842   PRBool isHTTP = PR_FALSE, isHTTPS = PR_FALSE;
843   iconURI->SchemeIs("http", &isHTTP);
844   iconURI->SchemeIs("https", &isHTTPS);
845   if (!isHTTP && !isHTTPS)
846     return NS_OK;

Simon, is there a specific reason you chose not to allow file:// icons?

Comment 3

[Simon Fraser [no longer active]]

(In reply to comment #2)
> Simon, is there a specific reason you chose not to allow file:// icons?

Yes, because with file:// there's no notion of the site root. We need to fall back on favicon.ico somewhere (for the non-link icons at least).

Maybe we could load local files for <link> favicons, but I'm worried that it might open up security issues. I'd WONTFIX this.