306726 - Should not have accesskey on a menulist option label

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Aaron Leventhal]

In Tools -> Options -> Advanced -> General -> Edit Languages we have a XUL
menulist which says.

[ _S_elect a language to add ]

This is the wrong way to do a label for a XUL menulist. The <label
control="menulist-id"/> should be outside of the control. Unfortunately XUL
menulist makes this confusing by offering a label attribute, but that actually
sets which item is initially selected.

Anyway, that accesskey doesn't actually work if you try it. I don't think we
should make it work, mainly because it's not really the right way to label a
menulist, although perhaps I'm not being open minded enough.

Comment 1

[Aaron Leventhal]

Attachment: Remove accesskey from menu option label

I suppose there's a deeper bug to be fixed here, but we need something simple
at least for branch.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 194551 [details] [diff] [review]
Remove accesskey from menu option label

r=mano. If this makes the branch as well, please don't checkin the DTD change.

Comment 3

[Asa Dotzler [:asa]]

time is short for beta so if this is gonna make the branch, it needs to land ASAP.

Comment 4

[Asa Dotzler [:asa]]

If this isn't landed today, it's not going to make the train.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I checked in the dtd change from this bug on the 1.8 branch since it wasn't checked in originally due to a l10n freeze.