306738 - uneval() on an object with getter or setter has unmatched parenthesis

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Liam Davis-Mead]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050901 SeaMonkey/1.1a

Doing something like
uneval(
{
   get foo()
   {
      return "foo";
   }
});

gives ({get foo(){return "foo";})}) as its output, which has a mismatched
parenthesis.  Unevaling a function results in (function(){}), so I suspect that
the getter/setter uneval code is delegating to the function uneval code,
stripping the leading "(" and then failing to strip the trailing ")".  Eval only
understands ({get foo(){return "foo";}}):  I can't stick an extra set of parens
around the getter in any way.

Reproducible: Always

Steps to Reproduce:
Click on the testcase URL.
Actual Results:  
({get foo(){return "foo";})}) is alerted.

Expected Results:  
({get foo(){return "foo";}}) should be alerted.

Also occurs in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Also occurs when using a setter, or when getters or setters have been added
using the (not-so) super-secret __define{S,G}etter__ object methods.

Comment 1

[Liam Davis-Mead]

Whoops.  I got confused by the shiny new bug wizard and filed this under general
browser instead of core javascript (I missed "other" on the main page).  Sorry
for the spam.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

I have a newfound liking of the decompiler. I'll take this.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Account for parentheses

The problem was that js_obj_toSource wasn't accounting for the parentheses at
all. This patch makes it do that (and removes the spurious space between the
getter name and the opening parameter parenthesis.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 194608 [details] [diff] [review]
Account for parentheses

Beef that comment up to avoid the window/orphan as discussed!

/be

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into MOZILLA_1_8_BRANCH and trunk.

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in regress-306738.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-306738.js,v  <--  regress-306738.js
initial revision: 1.1
done

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.x and trunk.