306760 - Bugzilla:Util is used (missing colon) - bz_crypt won't work

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Rob Siklos [:robzilla]]

checksetup.pl uses bz_crypt in certain situations, which makes use of the line

   eval("use Bugzilla:Util");

However, this line fails silently, and if bz_crypt needs to be called, an error
will occur.

The fix is easy - just add the missing colon between Bugzilla and Util, but I'm
worried that we got this far without noticing.  Is there any way to see if the
"use" command failed?

Comment 1

[Max Kanat-Alexander]

I'm surprised that test-checksetup didn't catch that... Ah well, it's easy
enough to fix.

Comment 2

[Max Kanat-Alexander]

Attachment: Fix the use and add a die

OK, here's a one-line patch that fixes the issue.

Comment 3

[Rob Siklos [:robzilla]]

When I apply this patch, checksetup dies (even with the correct "use"):

  Checking user setup ...
  Died at ./checksetup.pl line 1453.

Comment 4

[Frédéric Buclin]

Comment on attachment 194601 [details] [diff] [review]
Fix the use and add a die

Died at ./checksetup.pl line 1453.

Yup, sorry, right. checksetup.pl dies.

Comment 5

[Max Kanat-Alexander]

Attachment: Change it to a "require"

OK, I've changed it to use a "require" instead. I have no idea why it was
dying, but it was. ($! contained "Bad File Descriptor" but that might have been
from fixPerms or something else.)

Comment 6

[Frédéric Buclin]

Comment on attachment 194717 [details] [diff] [review]
Change it to a "require"

>-eval("use Bugzilla:Util");
>+require Bugzilla::Util;
>+import Bugzilla::Util qw(bz_crypt);

1491:	 (my $dbd_name = trim($my_db_driver)) =~ s/(\w+)/\u\L$1/g;
2003:	 $buffer = trim($buffer);
3441:		 $query_prod = "product=" . html_quote($product) . "&";

You have to import trim() and html_quote() too. Actually, globals.pl at line
1466 uses Bugzilla::Util, explaining why this syntax error has never been
caught and why bz_crypt() always worked as expected. But globals.pl is going to
die, and this problem will appear sooner or later. So let fix it now. My r+
with these two additional routines added.

Comment 7

[Max Kanat-Alexander]

Attachment: v3

Thanks for catching that. :-) OK, all fixed.

Comment 8

[Frédéric Buclin]

Comment on attachment 195179 [details] [diff] [review]
v3

r=LpSolit for both tip and 2.20

Comment 9

[Frédéric Buclin]

tip:

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.436; previous revision: 1.435
done

2.20rc2:

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.412.2.9; previous revision: 1.412.2.8
done