306796 - [adblocking] Still seeing Gmail ads with adblocking turned on

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Samuel Sidler (old account; do not CC)]

Summary says it all. Using 8/26 build.

The ads I'm seeing are on the right side (but are probably on the buttom, I just
haven't noticed them yet).

Comment 1

[François Gagné]

simple: the add in gmail don't come from
googlesyndication.com/pagead/show_ads.js they are (i think) directly rendered
into the page). Thus there are not blockable. This bug thus appear to be Invalid.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The right side "sponsored links" (is that what you're talking about?) are a
series of DIVs inside a DIV with id="rc".  That may be a fairly common DIV id,
given how generic it is.  The parent DIV has id="rh", so we might be able to do
something with that combo and child selectors or whatnot (the top part of "rh"
is another div with the "new window" and "print" images).  Other than that,
Gmail's not giving us much to go on.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fixes for this bug and others

OK, I have a fix for this (assuming the world is not full of useful divs with
id="rc" that are children of divs with id="rh"), bug 307849 comment 2
(googlebox on imdb), bug 310144, and (hopefully) bug 310721.  I can't repro the
latter one myself, so some testing by Samuel would be helpful (I'll upload the
modified ad_blocking.css for that).

Simon, do you have any regression-testing methodology that you use when adding
rules?	I don't visit a terribly wide range of sites, so it's hard for me to
say that there are no regressions, but I think the rules are fairly well
targeted.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Modified ad_blocking.css for use in non-dev testing

Samuel (and others), this goes in Camino.app/Contents/Resources

Comment 5

[Simon Fraser [no longer active]]

(In reply to comment #3)
> Created an attachment (id=198199) [edit]

> Simon, do you have any regression-testing methodology that you use when adding
> rules?	I don't visit a terribly wide range of sites, so it's hard for me to
> say that there are no regressions, but I think the rules are fairly well
> targeted.

I don't have any specific testing that I do. I just try to use well-targeted
rules, and I think these are OK.

Comment 6

[Simon Fraser [no longer active]]

Fixed.

Comment 7

[Simon Fraser [no longer active]]

Comment on attachment 198199 [details] [diff] [review]
Fixes for this bug and others

I checked in a variation of this.