306833 - update nsDocShell.cpp so that more errors can be "human readable"

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

nsDocShell has a set of logic that diagnoses http and page load errors and turns
them into either errors that are "human readable", meaning the URI and other
data is passed along with the error type ...

http://lxr.mozilla.org/mozilla/source/docshell/base/nsDocShell.cpp#2842

.. or errors that "require simple formatting", which only return the error type:

http://lxr.mozilla.org/mozilla/source/docshell/base/nsDocShell.cpp#2907

The new netError pages (landed at the time of Gecko 1.8) could benefit from more
"human readable" errors which can echo back the problem URI.

This bug requests that the following error states be converted/moved to "human
readable" errors:
    - deniedPortAccess
    - netReset
    - malformedURI
    - redirectLoop
    - unknownSocketType

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

For reference, see bug 306409 and bug 305998.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v0.1 (proposal)

This is a proposal for the final handling. I added all mentioned errors to the
human readable processing. I'm not really sure what string we should use for
'unknownSocketType'. Is scheme the correct one? 

Further I reordered the list of errors to find each of them a bit easier by
name.

I don't ask for review at this moment. I hope we could iterate to reach the
final code.

Comment 3

[:Gijs (he/him)]

Being bold and resolving as WFM. If there are still bits which are unfixed, please reopen! :-)