306841 - Ensure that extension update fails gracefully if invalid RDF is returned

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Darin Fisher]

Ensure that extension update fails gracefully if invalid RDF is returned.

In Firefox 1.0.x, if the RDF returned for extension update is invalid, then the
entire update system gets stuck.  We should ensure that this problem doesn't
happen in the extension update system for Firefox 1.5 as it would be unfortunate
if one bad extension screwed over the rest.

For reference, see bug 304873, where this problem came up.

Comment 1

[Robert Strong (they/them - no direct email)]

In bug 257976 the following scenarios were tested.

an invalid entry for updateURL as in bug 294640
an unavailable web site
an available web site without an update rdf
an available web site with a malformed update rdf
an available web site with an update rdf that is not for the extension being checked

As bug 304873 shows, this is a problem with 1.0.x and these scenarios are a good
start for ensuring this is fixed with the 1.8 branch.

Comment 2

[Robert Strong (they/them - no direct email)]

FYI: There are several comments related to the google toolbar and update in bug
307235 and hopefully this one issue is now resolved.

Comment 3

[Robert Strong (they/them - no direct email)]

I suspect that there will be issues around the download itself after the update
check completes as in bug 308721

Comment 4

[Dave Townsend [:mossop]]

Is there a reason to keep this bug open? I'm inclined at this point to close it out and just deal with particular cases as they come up.

Comment 5

[Robert Strong (they/them - no direct email)]

Agreed... there is already bug 343779 for tracking individual cases as well.