306850 - block print capability until page load done loading

Status: RESOLVED WORKSFORME

(Core :: Printing: Output, enhancement)

Description

[Wayne Mery (:wsmwk)]

similar to print preview

Comment 1

[Wayne Mery (:wsmwk)]

Attachment: Print Preview error message

see attached screen shot for example

Comment 2

[Jonathan Watt [:jwatt]]

This is WFM as reported, right? The testcase from bug 362475 doesn't trigger a dialog popup for me, and I don't think we have the text shown in your screenshot in the source code any more. Looking at the source we have mPrintIsPending checks in nsDocumentViewer nowadays to postpone printing until after the document has loaded, although mPrintIsPending code seemed to exist in 2002 prior to the filing of this bug (maybe it wasn't working properly back then and got fixed later?).

(As an additional note probably not relevant here, bug 407080 fixed some regressed load handling.)

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to Jonathan Watt [:jwatt] (needinfo? me) from comment #2)
> This is WFM as reported, right? The testcase from bug 362475 doesn't trigger
> a dialog popup for me, and I don't think we have the text shown in your
> screenshot in the source code any more. Looking at the source we have
> mPrintIsPending checks in nsDocumentViewer nowadays to postpone printing
> until after the document has loaded, although mPrintIsPending code seemed to
> exist in 2002 prior to the filing of this bug (maybe it wasn't working
> properly back then and got fixed later?).

Looks like that code was added in bug 137739, and that it did indeed postpone the Print() call until load.

Comment 4

[Wayne Mery (:wsmwk)]

Yes, I'd say so. Probably the dependencies are WFM also