306866 - context menu in message window shows to much options

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Onno Witvliet]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050902 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050831 Thunderbird/1.0+ ID:2005083109

The context menu gives options such as save image, while the message doesn't
contain images

Javascript Console shows:

Error: focusedWindow.__proto__ has no properties
Source File: chrome://communicator/content/nsContextMenu.js
Line: 709

Regressed between 20050830 and the 20050831 branch nightly builds
Works in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050830
Thunderbird/1.0+ ID:2005083009

Fails in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050831
Thunderbird/1.0+ ID:2005083109

Reproducible: Always

Steps to Reproduce:
1. Open message window
2. Right click anywhere in the message
3. The context menu opens

Actual Results:  
The context menu contains all options

Expected Results:  
The context menu should only contain the context dependent options

Comment 1

[David :Bienvenu]

yes, I see this too.

Comment 2

[David :Bienvenu]

Neil told me that this was because thunderbird had an old something, perhaps
nsContextMenu.js? I'll look at the xpfe one and see if it has some changes we want.

Comment 3

[Scott MacGregor]

fall out from the xpcnative wrapper change

Comment 4

[Scott MacGregor]

Attachment: the fix

same changes that were made to xpfe's nsContextMenu.js when the
xpcnativewrapper stuff was getting worked on.

Comment 5

[Scott MacGregor]

fixed branch and trunk