306878 - [Accessibility core only] Focus event not always fired for current focus, after Alt+Tab back to Firefox

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Aaron Leventhal]

Steps:
1. Turn on MSAA Inspect, and watch only focus events, and turn on focus highlighting
2. Optionally, start up accevent.exe event watcher
3. Place focus in location bar
4. Alt+tab twice

What happens:
Focus is on application window but should be in location bar

Comment 1

[Aaron Leventhal]

Attachment: Simple patch -- see below

When focus comes back to application root, update gLastFocusedNode to that
document node. That's a special case because we don't fire MSAA focus events
for the main window, since the system does it for us and that would be
redundant.

We have to keep gLastFocusedNode updated. The accessibility code has compares
the target of focus events with gLastFocusedNode in order to prevent the firing
of duplicate focus events.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 194693 [details] [diff] [review]
Simple patch -- see below

sr=jst

Comment 3

[Aaron Leventhal]

Comment on attachment 194693 [details] [diff] [review]
Simple patch -- see below

Low risk fix. Seeking a= for 1.8b4 on the basis that it is only in the
accessibility core and does not affect mainstream users.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 194693 [details] [diff] [review]
Simple patch -- see below

Lockdown for beta one happened last night and we've got candidates in hand so
this will need to wait until first thing in beta two.

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381