306893 - Wallpaper patch for better menu appearance in Thunderbird on Windows XP / Luna

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Grey Nicholson (they/them)]

Thunderbird version of bug 303806

Comment 1

[Grey Nicholson (they/them)]

Mirroring bug 303806's target milestone.

Comment 2

[Scott MacGregor]

not a blocker.

Please do not put bugs in milestones for me. Devs and triage teams only should
be changing that field. 

Comment 3

[zug_treno]

*** Bug 308274 has been marked as a duplicate of this bug. ***

Comment 4

[Shayne Jewers]

Attachment: port changes in menu.css and popup.css

This should do it

Comment 5

[Scott MacGregor]

Shayne, I don't think this patch is working quite right. In my test build, when
I mouse over the menubar, I get text jiggle amongst the menu bar text items as
we make space for the blue selection.

Comment 6

[Scott MacGregor]

correction, it looks like when I mouse over a menubar item, the selection takes
up less width than non selected, so things get moved in, then when i move
selection away, the menu bar text nodes get wider.

Comment 7

[Scott MacGregor]

Shayne, can you help out with a new patch here?

Comment 8

[Shayne Jewers]

Attachment: Patch v2

should do it

Comment 9

[Scott MacGregor]

Comment on attachment 197987 [details] [diff] [review]
Patch v2

hmm, I still get the same jiggle action in the menu bar with this patch when
moving focus over the menu items.

Comment 10

[Shayne Jewers]

hmm, i ported all the changes from patch 195008, so this sounds like that
problem is another issue

Comment 11

[Grayson Mixon (ColdFusion650)]

on account of them almost done with native theme renderin and on account of all
the outcry when somethin like this was landed on firefox, would this be for the
best? perhaps hold off until native theme renderin is done.

Comment 12

[Scott MacGregor]

pushing this off the 1.5 release list since we can't seem to get a patch that
works. This should get adddressed without this patch once the xp native theme
renderer improvements land anyway.

Comment 13

[Scott MacGregor]

now that we use winstripe in toolkit, we are already getting the changes from 303806 so there's nothing left to port here.