306942 - about-window changes after you've opened about:plugins

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Jo Hermans]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050902
Firefox/1.0+
(1.8 branch, Mac OS X 10.2.8)

The "About Deer Park alpha 2" window changes after you've selected about:plugins.

1. start Deer Park alpha 2
2. open up the "about ..." window (see before.png) - DP customized window
3. open up about:plugins
4. open up the "about ..." window (see after.png) - generic window

(I'll post the screenshots in a minute)

I couldn't find a duplicate in bugzilla. It might be related to the recent
branding changes, and it might go away when we switch back to the official branding.

Comment 1

[Jo Hermans]

Attachment: before

Comment 2

[Jo Hermans]

Attachment: after

Comment 3

[Jo Hermans]

Note that the generic about-box is sticky to your window, even in other tabs, or
if you close the tab with about:plugins. But if you open a new window, it will
have the originasl about-box again.

Comment 4

[Asaf Romano (gone)]

(wtf)

Is this a regression?

Comment 5

[Asaf Romano (gone)]

can't reproduce on:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050818
Firefox/1.0+

Comment 6

[Mark Mentovai]

(In reply to comment #5)
> can't reproduce on:
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050818
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
Is that some sort of joke?

Using 2005090305 (1.8), I'm unable to reproduce in 10.4.2, but am able to
reproduce in 10.3.9.  This is caused by loading the JEP bundle.  The about
window also reverts to the system default when a window hosts any Java applet
via JEP, about:plugins and running an applet both cause JEP to load.

Comment 7

[Asaf Romano (gone)]

Er, this was a custoimized UA i forgot i'm using in this profile, sorry.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

Anybody here familiar with where (in the Mozilla) source the decision is made
that determines which "about window" is displayed?  I think the only way I'm
going to be able to track this down is by starting from the browser side.

Comment 9

[Steven Michaud [:smichaud] (Retired)]

This is an _old_ problem.  It happens with Firefox 1.0.6, and with versions of
the JEP at least as far back as 0.8.9.  Odd that no-one (including myself)
ever noticed it before.

It's also very odd that it happens on OS X 10.2.8 and 10.3.9, but not 10.4.2.

Comment 10

[Steven Michaud [:smichaud] (Retired)]

> Anybody here familiar with where (in the Mozilla source) the decision is
> made that determines which "about window" is displayed?

Never mind.  I've figured this out.  The simple little "about window" (the one
pictured in attachment 194753 [details]) seems to be built by the OS itself from
information in Contents/Info.plist and
Contents/Resources/en.lproj/InfoPlist.strings.  In other words, the "Deer Park
: About Deer Park Alpha 2" and "Firefox : About Mozilla Firefox" menu items
seem to have reverted to the OS default.

Now I need to figure out why _that_ happens :-)

Comment 11

[Mark Mentovai]

I hope it's not so terrible that ANY call to CFBundleLoadExecutable() would
cause this.

Comment 12

[Steven Michaud [:smichaud] (Retired)]

No, I'm quite sure not.  This is probably yet another bug in Apple's
Cocoa-Carbon interface (one that got fixed in Tiger).

I'm going to start playing around with Carbon menu events, to see what I can
do.

Comment 13

[Steven Michaud [:smichaud] (Retired)]

I've now got this problem fixed (that is, I found a way to work around the
Apple bug(s)).

Is this problem important enough that it should get its own Java Embedding
Plugin "nightly", or should I wait until I've accumulated some more fixes?

Comment 14

[Steven Michaud [:smichaud] (Retired)]

The fix for this is now incorporated in version 0.9.4 of the Java Embedding
Plugin, which I've just released:

http://javaplugin.sourceforge.net/

Comment 15

[Jo Hermans]

Seems to be fixed in 
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20050927
Firefox/1.4

which should includes JEP 0.9.4+a, from bug 308549. I'm running a fresh install
with the old profile, not an automatic updated one. 

I wanted to close this bug, but I can't see the JEP in my about:plugins at all.
Just the OJI plugin 1.0 and the 2 Java Plugins 1.3.1. Is this normal ?

Comment 16

[Jo Hermans]

Note: I can see the Java Embedded Plugin (0.9.4+a, the new version) in my
package, but not in about:plugins.

Comment 17

[Steven Michaud [:smichaud] (Retired)]

Yes, this problem is fixed in JEP 0.9.4 and later versions.  The current JEP
version (and the one that's included as of today (2005-09-27) with nightlies
on the trunk and 1.8 and Camino-1.0 branches) is 0.9.4+a.

> Note: I can see the Java Embedded Plugin (0.9.4+a, the new version) in my
> package, but not in about:plugins.

If you look closely at the about:plugins info for the "OJI Plugin for Mac OS
X", you'll see an "MRJ Plugin JEP" link that goes to
http://javaplugin.sourceforge.net/.  The "OJI Plugin for Mac OS X" _is_ the
Java Embedding Plugin (or more accurately the MRJ Plugin JEP that comes with
it, and which launches JavaEmbeddingPlugin.bundle).

I think I could do a better job of identifying this as belonging to the JEP :-)

I might also be able to include a link to a Java testing site, so people can
more easily find out which version of Java they're using.  (I can't just
specify this directly -- the JEP runs different Java versions on different
versions of OS X, but the information in the about:plugins display is
statically linked (it can't be changed at runtime).  See bug 310078.)

Comment 18

[Jo Hermans]

ok, it's fixed then. I see the correct about-window, and the OJI Plugin contains
a  <a href="http://javaplugin.sourceforge.net/">MRJ Plugin JEP</a> link, so it's
the correct one.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20050927
Firefox/1.4