306971 - Blank area appears above preferences tree when collapsing it

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050217] (<-- 1.8b1 !)
(W98SE)

No bug.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050902 SeaMonkey/1.1a]
(nightly) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050903 SeaMonkey/1.1a]
(nightly) (W98SE)

1. Open Browser Preferences
2. Expand 1+ node
3. Scroll to bottom
4. Collapse 1+ node

R. The tree moves down;
   instead of staying at the top of the window.

Comment 1

[[e-mail]]

Ewww. I remember at one point I had it such that it didn't scroll up and left
blank space at the bottom but this is definitely worse :-)

Comment 2

[[e-mail]]

Another regression from bug 212789 - the old code didn't bother updating hidden
scrollbars because it caused the range to be negative.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Since we can't early return any more I copied the horizontal scrollbar code.

Comment 4

[Felix Miata]

I saw something like this yesterday or this AM in the 31 or 02 trunk, but in
history. When I collapsed the last open folder, a column of empty twisties (all
blank to their right) was left above the valid folders. I have not been able to
repro.

Comment 5

[Felix Miata]

Attachment: screenshot

What I mentioned in comment 4 just happened again in same 2005090203 OS/2
trunk.

Comment 6

[[e-mail]]

Comment on attachment 194921 [details]
screenshot

Yup, that's the same bug. The basic bug is that the top line is negative.
Anything painted above line 0 is just basically random.

Comment 7

[[e-mail]]

Fix checked in.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using SeaMonkey 1.1a

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050917 Mozilla/1.0