306989 - top pane is one line tall when starting up

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Mark Harrison]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

On mac os x.  Installed sunbird and ran it for the first time.

The top pane showing the event list was only one line long.
It should be several lines long, so it will be identifiable
as a list of events.

After resizing manually, everything was great.

Reproducible: Always

Steps to Reproduce:
1. install sunbird
2. run sunbird
3. look at top pane

Actual Results:  
top pane was one line tall and did not look like
like a list.

Expected Results:  
Showed several lines, so that it was recognizable
as a list of events.

it looks VERY GOOD so far!

Comment 1

[Joey Minta]

Attachment: declare height

The unifinder is definitely small on startup with a clean profile, but it's
also empty, so not much is missing.  Still, it's SO narrow that users could
find it confusing, and it almost always ends up getting resized.  If we
explicitly declare the height of the box, then on first start-up it will be
bigger, and persist="height" will still override, so everyone is happy.  (120
gives about 3 tree-rows height for me).

Comment 2

[Simon Paquet [:sipaq]]

Comment on attachment 194791 [details] [diff] [review]
declare height

>-      <vbox id="bottom-events-box" persist="height">
>+      <vbox id="bottom-events-box" height="120" persist="height">

IMO stuff like "height" should go into calendar.css, where it can be customized
by themers. I would also recommend using a 'em' value here to better cope with
larger or smaller fonts.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

does persist= override the setting fomr the .css?

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 194791 [details] [diff] [review]
declare height

>+      <vbox id="bottom-events-box" height="120" persist="height">

Why not set the height on the tree itself? That's is where the problem is.
You could also try to play with flex settings, to make the tree something like
25% of the height.

Comment 5

[Joey Minta]

Comment on attachment 194791 [details] [diff] [review]
declare height

See mvl's comments.

Comment 6

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 7

[Martin Schröder [:mschroeder]]

Was this fixed with the patch from bug 355360?

Comment 8

[Omar Bajraszewski]

(In reply to comment #7)
> Was this fixed with the patch from bug 355360?
> 
I also think it has been fixed

Comment 9

[Martin Schröder [:mschroeder]]

This was fixed with the patch from bug 355360.