307024 - named named anchor links cause exception in phishingDetector.js :: isPhishingURL

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin]]

Loading a message that contains a remote image throws an exception. 

Error: [Exception... "Component returned failure code: 0x804b000a
[nsIIOService.newURI]"  nsresult: "0x804b000a (<unknown>)"  location: "JS frame
:: chrome://messenger/content/phishingDetector.js :: isPhishingURL :: line 64" 
data: no]
Source File: chrome://messenger/content/phishingDetector.js
Line: 64

I see this using version 1.5 Beta 1 (20050903) and going back to at least start
of april. But not in thunderbird 1.0.x.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: example

When opening this example mail as a standalone message there are a lot of other
exceptions also. They don't appear loading it from the mailbox though.

Comment 2

[Ian Neal]

In the function isPhishingURL, does adding, after var href = aLinkNode.href; :

if (!href)
  return false;

fix it?

Comment 3

[Magnus Melin [:mkmelin]]

(In reply to comment #2)
> In the function isPhishingURL, does adding, after var href = aLinkNode.href; :
> 
> if (!href)
>   return false;
> 
> fix it?

Yep, thanks. Patch coming up.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

This fixes it. No exceptions for when loaded from mailbox.

Comment 5

[Scott MacGregor]

Comment on attachment 195044 [details] [diff] [review]
proposed fix

thanks for the patch

Comment 6

[Scott MacGregor]

fixed branch and trunk