307028 - auto-save happens even if message is currently being sent

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Ravi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+
Build Identifier: version 1.6a1 (20050902)


1. The new Auto-save every "x" minutes feature for messages being composed locks
up the composition window and addressing pane whenever it does a save. Auto-save
is expected to be a background save and not lock up compose window. Over a slow
IMAP connection this is really annoying when it tries to save and locks up for
as long as it takes for it to save the message *and* and attachment to server drafts

2. when a message that was auto-saved was canceled without sending, the saved
draft is not being deleted. This should be deleted unless the user chose to
explicitly save to draft. 

3. Auto-save is saving the message even after pressing "send" during the time it
takes to send/transfer the message. It should ideally save only when composing.

4. Auto-save should is also saving the attachment in the compose message -
ideally it should save only the text being typed and a reference to the local
file attacchment (that gets automatically attached when opened from drafts again)

5. Auto-save uses the drafts folder for the account from which the message is
being composed, for saving it. It should ideally use the local drafts folder
which is much faster and improves bandwidht performance - especially over slow
IMAP links.


Reproducible: Always

Steps to Reproduce:
1. Open a new message window
2. Observe the 5 behaviours listed above

Actual Results:  

Compose window is locked up for the duration auto save tries to save.


Expected Results:  

Auto-save should work in background using local drafts folder for saving - see
the 5 points in description.

Comment 1

[Adam Guthrie]

One issue per bug please. Issue #3 is bug 288534. 

*** This bug has been marked as a duplicate of 288534 ***

Comment 2

[Ravi]

(In reply to comment #1)

OK, will open separate reports for issues other than 3.

As for issue 3, it is not the same as 288534. 288534 bug referred to removing
already saved copies from drafts. However I refer to attempting to auto-save
even when the send is in progress. When the message size is large and it takes
TB longer time to after pressing send to transfer it to SMTP server than the
auto-save interval, TB initiates auto-save. Ideally it should stop auto-saving
after send is pressed, even if the compose window is still open waiting for the
transfer to complete.

To reproduce this, follow the steps -
1. Open compose and attach a large file, one that takes more time to post to
SMTP than the auto-save interval (would help to set autosave interval to a low
value and use a dialup to SMTP)
2. Press send and notice send progress and autosave progress. Autosave still
initiates in this stage. This is neither required nor expected - it slows down
the send process if the drafts folder is on a server.

Also, note that the bug 288534 is marked fixed but I still see the above
behaviour on 20050902 nightly.

Re-opening this bug based on above report.

Comment 3

[Ravi]

Attachment: Testcase - GIF showing the first stage, just after pressing send on a mail with big attachment (refer 2.gif for next observation)

Attached testcase observation-1 - first GIF showing screencapture just after
pressing send on a mail with big attachment - TB starts sending normally. Now
refer the next attachment for the observation-2 of the bug.

Comment 4

[Ravi]

Attachment: Second gif showing the bug - TB startes saving to drafts even after send is in progress

Attached testcase observation-2 - second GIF showing screencapture sometime
after pressing send on a mail with big attachment - TB initially starts sending
normally but then it starts auto-saving to drafts folder too! You can see the
send progress and the status bar which indicates auto-save to deafts.

Comment 5

[David :Bienvenu]

OK, changing summary, since auto-save shouldn't happen during send.

Comment 6

[Scott MacGregor]

this sounds like a 1.1 blocker right David?

Comment 7

[David :Bienvenu]

Attachment: proposed fix

don't auto save if we're already saving/sending

Comment 8

[Ravi]

Would this proposed fix still work if, after message-send, TB starts copying the
message to sent folder (also on a slow connection over IMAP for instance)? Or
during any other operation that may possibly occur after composition.

I mean, is this a foolproof way to indicate end of composition for auto-save?

Comment 9

[Scott MacGregor]

Comment on attachment 195943 [details] [diff] [review]
proposed fix

go ahead and put this on the branch too david.

Comment 10

[David :Bienvenu]

this prevents auto-save during the whole send process, including copy to an
online sent folder.