307047 - stackTraceFunctionFormat(aFunctionName) as typo error

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Tei]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.7.8) Gecko/20050517 Firefox/1.0.4 (Debian package 1.0.4-1)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.7.8) Gecko/20050517 Firefox/1.0.4 (Debian package 1.0.4-1)

I am running firefox with debugger mode set to pedantic. Theres a few errors on
firefox itself I guest can generate other errors.

On stackTraceFunctionFormat(aFunctionName)

The code:
  if (!functionName) 
    functionName == "<anonymous>";
sould be:
  if (!functionName) 
    functionName = "<anonymous>";

My version is:
Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.7.8) Gecko/20050517 Firefox/1.0.4
(Debian package 1.0.4-1)


Reproducible: Always

Steps to Reproduce:
1. activate debugging
2. look at javascript console
3. Profit!

Actual Results:  
Info on log appear:

-----
Advertencia: useless expression
Archivo de origen: file:///usr/lib/mozilla-firefox/components/nsExtensionManager.js
Línea: 337

Expected Results:  
Zero boogs!

Comment 1

[Adam Guthrie]

Attachment: patch v1

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 194853 [details] [diff] [review]
patch v1

That is part of Ben's debug code which has been ifdef'd so it is preprocessed
out of nsExtensionManager.js except on the aviary 1.0.x branch and afaik
patches to just fix strict warnings aren't accepted for aviary. The patch is
fine but I would  prefer if you asked Ben to review it since it isn't part of
the build now and he may prefer to change it or remove it entirely.

Comment 3

[u88484]

Comment on attachment 194853 [details] [diff] [review]
patch v1

Just going through some bugs and noticed this patch needed ben to review it

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed on trunk by the checkin for bug 329045