307058 - Folder Properties dialog's Retention Policy tab has incorrectly aligned captions

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Ale Mand]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050903 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050903 Firefox/1.6a1

Captions to the right and to the left of the textbox are not correctly aligned

Reproducible: Always

Steps to Reproduce:
1.right click on rss feed
2.click retention policy tab
3.look 

Actual Results:  
Not aligned text

Expected Results:  
Text should be aligned

Comment 1

[Ale Mand]

Attachment: Example of the cosmetic glitch

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Fixes the alignment.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: screenshot after the fix

Comment 4

[Scott MacGregor]

Comment on attachment 248169 [details] [diff] [review]
proposed fix

nice fix magnus.

Comment 5

[Ale Mand]

I still think the captions are misaligned, as shown in the proposed fix

Comment 6

[Magnus Melin [:mkmelin]]

In what way do you expect them to be?

Comment 7

[Ale Mand]

I would expect "messages" vertically aligned with "Delete all but the last" and I would expect "days old" vertically aligned with "Delete messages more than".

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Takes care of the other mis-alignment too...

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: screenshot after the fix, v2

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: screenshot after the fix, v2, correct file...

Comment 11

[TT]

The text in image 248281 is still not align.  "days old" is one pixel higher than "Delete messages more than".

Also, is this fix going into Seamonkey as well, or just Thunderbird?

Comment 12

[Magnus Melin [:mkmelin]]

Maybe... but that's the way it is a few other places also, I guess.  
It fixes seamonkey as well.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/base/resources/content/folderProps.xul 	1.24
mozilla/mailnews/base/resources/content/folderProps.xul 	1.21.2.2

Comment 14

[TT]

How can you consider this bug fixed?  The text is still misaligned!  At least, according to the latest screenshot.  Sure, it's only off by one pixel instead of several, but why can't you just get it 100% right?  I don't understand why this is so difficult.

Comment 15

[Magnus Melin [:mkmelin]]

Timur: this corrected the markup. I have no idea where the 1px is coming from, if it's some kind of rounding error or some default css rule that makes it look that way. Or if it just happens to look like that with the fonts on my system.

(but since i *think* i see the 1px off in a few similar places in the prefs as well, it's likely some core bug)

Comment 16

[Ale Mand]

WFM. I think Timur wants to be funny, although this is some sort of humor I just don't get.

Comment 17

[TT]

I'm not trying to be funny.  Read my comment #11.  In the attached image, the text is clearly still not aligned.

If you guys are convinced that this is as good as it's going to get, then I'll stop complaining.