307061 - Don't support Cmd+F5 for "Force Reload" on OS X

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect, P2)

Description

[Asaf Romano (gone)]

Starting from OS X 10.4, Cmd+F5 is the default OS global keyboard shortcut for
turning on "Voice Over". We shouldn't try to override it.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 194868 [details] [diff] [review]
patch

r=gavin

Comment 3

[Asaf Romano (gone)]

Trunk:
Checking in browser/base/content/browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.55; previous revision: 1.54
done
Checking in browser/locales/en-US/chrome/help/shortcuts.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml,v  <-- 
shortcuts.xhtml
new revision: 1.37; previous revision: 1.36
done

Comment 4

[Scott MacGregor]

Comment on attachment 194868 [details] [diff] [review]
patch

triage team: this looks very low risk.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Verified.

Comment 6

[Asa Dotzler [:asa]]

Time is short for 1.8b4. If this isn't landed today, it's not going to make the
train.

Comment 7

[Asaf Romano (gone)]

1.8 branch:
Checking in base/content/browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.51.2.5; previous revision: 1.51.2.4
done
Checking in locales/en-US/chrome/help/shortcuts.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml,v  <-- 
shortcuts.xhtml
new revision: 1.34.4.3; previous revision: 1.34.4.2
done

Comment 8

[Tracy Walker [:tracy]]

verified with Mac Fx 1.4 2005-09-08-06-mozilla1.8