Don't support Cmd+F5 for "Force Reload" on OS X

VERIFIED FIXED in Firefox1.5

Status

()

Firefox
Keyboard Navigation
P2
normal
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

({late-l10n, verified1.8})

1.5.0.x Branch
Firefox1.5
PowerPC
Mac OS X
late-l10n, verified1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Starting from OS X 10.4, Cmd+F5 is the default OS global keyboard shortcut for
turning on "Voice Over". We shouldn't try to override it.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firefox1.5
Created attachment 194868 [details] [diff] [review]
patch
Attachment #194868 - Flags: review?(gavin.sharp)
Comment on attachment 194868 [details] [diff] [review]
patch

r=gavin
Attachment #194868 - Flags: review?(gavin.sharp) → review+
Trunk:
Checking in browser/base/content/browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.55; previous revision: 1.54
done
Checking in browser/locales/en-US/chrome/help/shortcuts.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml,v  <-- 
shortcuts.xhtml
new revision: 1.37; previous revision: 1.36
done
Flags: blocking1.8b5?
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Keywords: late-l10n
Attachment #194868 - Flags: approval1.8b5?
Attachment #194868 - Flags: approval1.8b4?

Comment 4

12 years ago
Comment on attachment 194868 [details] [diff] [review]
patch

triage team: this looks very low risk.
Verified.
Status: RESOLVED → VERIFIED

Updated

12 years ago
Attachment #194868 - Flags: approval1.8b5?
Attachment #194868 - Flags: approval1.8b4?
Attachment #194868 - Flags: approval1.8b4+

Comment 6

12 years ago
Time is short for 1.8b4. If this isn't landed today, it's not going to make the
train.
1.8 branch:
Checking in base/content/browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.51.2.5; previous revision: 1.51.2.4
done
Checking in locales/en-US/chrome/help/shortcuts.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml,v  <-- 
shortcuts.xhtml
new revision: 1.34.4.3; previous revision: 1.34.4.2
done
Flags: blocking1.8b5?
Keywords: fixed1.8

Comment 8

12 years ago
verified with Mac Fx 1.4 2005-09-08-06-mozilla1.8
Keywords: fixed1.8 → verified1.8
You need to log in before you can comment on or make changes to this bug.