307109 - increase height of URL text box in Open Location dialog

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[Hari Kumar G]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20050903
Firefox/1.6a1

Hide the navigation bar.  Press Ctrl + L to open the 'Open Web Location' dialog.
 The height of the box to type in the address is a little bit less that what is
normally available elsewhere.  see screenshot.  

I do know that this is trivial but perhaps much easy to rectify. please.

[even with other themes this 'defect' is visible.]

Comment 1

[Martijn Wargers (dead)]

That would by removing align="center" in this line:
http://lxr.mozilla.org/seamonkey/source/browser/base/content/openLocation.xul#69

Comment 2

[Martijn Wargers (dead)]

Attachment: patch

This fixes it.

Comment 3

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050905
Firefox/1.0+ ID:2005090509

same on branch

Comment 4

[Adam Guthrie]

*** Bug 301747 has been marked as a duplicate of this bug. ***

Comment 5

[zug_treno]

Also reproducible with Mozilla 1.8b1 and SeaMonkey/20050904 (Ctrl+Shift+L).

Comment 6

[Martijn Wargers (dead)]

Attachment: patch for Seamonkey

Oops! Forgot that one.
This is untested, but should act the same as Firefox.

Comment 7

[[e-mail]]

Comment on attachment 195058 [details] [diff] [review]
patch for Seamonkey

Well, to start with, we also have the similar attachWebPage dialog. But in fact
this is not the correct way to fix the issue; the URL bar is mostly
unreasonably large because the page proxy icon has margins on it, as you would
see if you compared it with DOM Inspector's autocomplete box. Now the open
location dialog's autocomplete textbox doesn't have an icon to enlarge it, so
it should only be the same size as a regular textbox. Unfortunately in either
Classic or Modern themes it seems to be a pixel or two out :-(

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Why does that patch fix it, though?

Comment 9

[[e-mail]]

(In reply to comment #8)
>Why does that patch fix it, though?
It doesn't, it makes the hbox stretch the textbox to the height of the button.

Comment 10

[Dão Gottwald [:dao]]

This dialog is dead code now. See bug 953124.