307111 - [FIX]nsSimplePageSequenceFrame::Paint does not override nsIFrame::Paint

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Instead it shadows it, because it's missing a flags parameter. I suspect that
this is not what was intended. This is probably not too important, although this
may mean that the white background isn't painted.

It also sets the color of the rendering context twice:
982   aRenderingContext.SetColor(NS_RGB(255,255,255));
983 
984 
985   if (NS_FRAME_PAINT_LAYER_BACKGROUND == aWhichLayer) {
986     nsRect rect = mRect;
987     aRenderingContext.SetColor(NS_RGB(255,255,255));

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yeah, this is odd... it's also been this way forever, so maybe this method is
not even needed?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Let's delete it. We can resurrect it if we ever decide we want it.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: so thus?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed