307124 - Pressing Enter in the update wizard moves forward regardless of update state

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Asaf Romano (gone)]

Pressing Enter in the update wizard moves forward regardless of update state.

STR:
 1. Download an update
 2. During the download, press Enter.

-> The wizard says the download is complete and suggests to restart.

Comment 1

[Adam Guthrie]

Attachment: screenshot after I restarted after pressing enter

Seeing this on Windows and Linux, too. Some weird behavior on Windows... it's
like it still wanted to download the update before it installed it (good). But
I can't say that the same happened on Linux. It seemed like it tried to install
a partial update. I'll do some more testing.

Comment 2

[Asa Dotzler [:asa]]

darin, ben, what do you think about this?

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Don't allow _hitEnter to fire the default button if it's not enabled. In other
news, this binding isn't fun - it should be possible to easily access the
current defualt button.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 194936 [details] [diff] [review]
patch

This is wrong, the wizards that are breaking on this should be setting
this.canAdvance to disable the button, not disabling it directly.  If that's
done, this hack is unnecessary.

Comment 5

[Asa Dotzler [:asa]]

Mike, how close are you to a fix here? We're getting very short on time.

Comment 6

[Mike Connor [:mconnor]]

Attachment: make wizards use canAdvance

Comment 7

[Mike Connor [:mconnor]]

Attachment: Not Horked version of the patch

Comment 8

[Mike Connor [:mconnor]]

Attachment: gah

I'd so love NyQuil and 16 hours sleep right about now....

Comment 9

[Asaf Romano (gone)]

Comment on attachment 195087 [details] [diff] [review]
gah

This blocks the import wizard in the importing step.

Comment 10

[Mike Connor [:mconnor]]

Attachment: gah x2

Comment 11

[Asaf Romano (gone)]

Comment on attachment 195093 [details] [diff] [review]
gah x2

>-    bb.disabled = backButtonDisabled;
>-    bn.disabled = nextButtonDisabled;
>+    

Remove whitespace in this line.

r=mano.

Comment 12

[Scott MacGregor]

fixed on the branch. I'll let mike land this on the trunk at his leisure. 

I also filed a bug and fixed thunderbird's migration wizard (will land in 1.8b5)

Comment 13

[Mike Connor [:mconnor]]

Fixed on trunk now too.