Closed Bug 307169 Opened 19 years ago Closed 19 years ago

change the kbd shortcut for 'Check for Updates' to 'U'

Categories

(Firefox :: Keyboard Navigation, defect)

defect
Not set
minor

Tracking

()

RESOLVED WONTFIX
Firefox1.5

People

(Reporter: harig.in, Assigned: Gavin)

Details

Attachments

(1 file)

the menu item 'Check for updates' has a keyboard shortcut 'o'. Could be better /
consistent if 'u' is used. (Alt + h + u - to launch the update dialog in Windows)
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Hardware: PC → All
Attachment #195599 - Flags: review?(mconnor)
Whiteboard: [patch-r?]
Comment on attachment 195599 [details] [diff] [review]
patch

ok, but why did you move it below the label, but not flip the one right above
that's also backwards?	Please fix this (trivial) on checkin.
Attachment #195599 - Flags: review?(mconnor) → review+
Whiteboard: [patch-r?] → [patch-r+][checkin needed]
Target Milestone: --- → Firefox1.5
mozilla/browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd;
new revision: 1.5; previous revision: 1.4
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r+][checkin needed]
Comment on attachment 195599 [details] [diff] [review]
patch

Trivial change, makes the update menu easier to access.
Attachment #195599 - Flags: approval1.8b5?
Attachment #195599 - Flags: approval1.8b5? → approval1.8b5+
Keywords: late-l10n
This doesn't have any localization impact, since it only changes the accesskey
for the en-US string.
Keywords: late-l10n
mozilla/browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd; new revision:
1.4.4.1;
Keywords: fixed1.8
Comment on attachment 195599 [details] [diff] [review]
patch

This doesn't play well with the dynamic label of this menuitem.
Attachment #195599 - Flags: review+ → review-
Status: RESOLVED → REOPENED
Keywords: fixed1.8
Resolution: FIXED → ---
Backed out branch and trunk.
Status: REOPENED → RESOLVED
Closed: 19 years ago19 years ago
Resolution: --- → WONTFIX
Attachment #195599 - Flags: approval1.8b5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: