307230 - "Default Alarm Setting for events" to "on" is ignored

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[jrx]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050906 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050906 Mozilla Sunbird/0.2+

I have set "Default Alarm Setting for events" to "on", but when I make a new
event the alarm on the event is set to off. 

Reproducible: Always

Steps to Reproduce:
1.Tools>Options>Alarms
2.Set "Default Alarm Setting for events" to "on" and choose a time interval
3.Create a new event

Actual Results:  
In the new event window, the alarm is set to off.

Expected Results:  
The alarm should be on with the specified time interval.

Comment 1

[Robin Edrenius]

Confirming on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1)
Gecko/20050907 Mozilla Sunbird/0.2+

Status: New

Comment 2

[Joey Minta]

Attachment: honor alarm preferences

This patch adds alarm times to the newEvent and newToDo functions.  For
newToDo, this requires setting an entryDate (not entryTime as the code
currently says), in order to have something to base the alarm off of.  Also
note that you can't access todo.entryDate.jsDate if there was no original
entryDate, so we work around that using jsDateToDateTime().

The event dialog was pretty badly messed up for handling the case of todo
alarms as well.  (It always ended up disabled, even if an alarm was previously
set.)

Apologies for the collection of bug fixes.  I'll split this patch if asked.

Comment 3

[Joey Minta]

Patch checked in