307245 - ASSERTION: FormatStringFromName() without format parameters: use GetStringFromName() instead: 'aParams && aLength' @ nsStringBundle::FormatStringFromName(

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Bob Clary [:bc] (inactive)]

Found with a CVS Firefox 1.5 build from 2005-09-05

ASSERTION: FormatStringFromName() without format parameters: use
GetStringFromName() instead: 'aParams && aLength', file
c:/work/mozilla/builds/ff/1.5/mozilla/intl/strres/src/nsStringBundle.cpp, line 226

nsStringBundle::FormatStringFromName(nsStringBundle * const 0x03361a18, const
unsigned short * 0x0012f138, const unsigned short * * 0x0012f398, unsigned int
1, unsigned short * * 0x0012f418) line 226
nsStringBundle::FormatStringFromID(nsStringBundle * const 0x03361a18, int 3,
const unsigned short * * 0x0012f398, unsigned int 1, unsigned short * *
0x0012f418) line 215 + 36 bytes
nsStringBundleService::FormatWithBundle(nsIStringBundle * 0x03361a18, unsigned
int 2152398851, unsigned int 1, unsigned short * * 0x0012f398, unsigned short *
* 0x0012f418) line 777 + 34 bytes
nsStringBundleService::FormatStatusMessage(nsStringBundleService * const
0x00f6d9c0, unsigned int 2152398851, const unsigned short * 0x0012f4c0, unsigned
short * * 0x0012f418) line 847 + 33 bytes
nsDocLoader::OnStatus(nsIRequest * 0x0320c1e8, nsISupports * 0x00000000,
unsigned int 2152398851, const unsigned short * 0x0012f4c0) line 1066 + 55 bytes
nsHttpChannel::OnTransportStatus(nsHttpChannel * const 0x0320c204, nsITransport
* 0x00000000, unsigned int 2152398851, unsigned __int64 0, unsigned __int64 0)
line 4188 + 105 bytes
nsTransportStatusEvent::HandleEvent(PLEvent * 0x03366ce8) line 125
PL_HandleEvent(PLEvent * 0x03366ce8) line 688 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00f4a498) line 623 + 9 bytes
nsEventQueueImpl::ProcessPendingEvents(nsEventQueueImpl * const 0x00eddea0) line
419 + 12 bytes
nsWindow::DispatchPendingEvents() line 4211
nsWindow::ProcessMessage(unsigned int 256, unsigned int 13, long 1835009, long *
0x0012faac) line 4511
nsWindow::WindowProc(HWND__ * 0x001203bc, unsigned int 256, unsigned int 13,
long 1835009) line 1434 + 27 bytes
USER32! 77d48734()
USER32! 77d48816()
USER32! 77d489cd()
USER32! 77d48a10()
nsAppShell::Run(nsAppShell * const 0x00f515f8) line 135
nsAppStartup::Run(nsAppStartup * const 0x00f51558) line 145 + 26 bytes
XRE_main(int 3, char * * 0x003f6f60, const nsXREAppData * 0x0042201c kAppData)
line 2322 + 35 bytes
main(int 3, char * * 0x003f6f60) line 61 + 18 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL3

Comment 1

[Simon Montagu :smontagu]

This is curious, because on the given URL I get the same assertion but with a
completely different stack.

Comment 2

[Bob Clary [:bc] (inactive)]

(In reply to comment #1)
> This is curious, because on the given URL I get the same assertion but with a
> completely different stack.

My stack is totally bogus. I was setting the breakpoint wrong on the assertion.
Please use _your_ stack.

Comment 3

[Simon Montagu :smontagu]

NTDLL! 77f75a58()
nsDebugImpl::Assertion(nsDebugImpl * const 0x002a95c0, const char * 0x01d53da0,
const char * 0x01d53d8c, const char * 0x01d53d38, int 0x000000e2) line 266
NSGlue_Assertion(const char * 0x01d53da0, const char * 0x01d53d8c, const char *
0x01d53d38, int 0x000000e2) line 107
nsStringBundle::FormatStringFromName(nsStringBundle * const 0x033e83a0, const
unsigned short * 0x0012d874, const unsigned short * * 0x00000000, unsigned int
0x00000000, unsigned short * * 0x0012d8f8) line 226 + 38 bytes
nsContentUtils::FormatLocalizedString(nsContentUtils::PropertiesFile
eLAYOUT_PROPERTIES, const char * 0x016361c8, const unsigned short * *
0x00000000, unsigned int 0x00000000, nsXPIDLString & {???}) line 2308 + 67 bytes
nsContentUtils::ReportToConsole(nsContentUtils::PropertiesFile
eLAYOUT_PROPERTIES, const char * 0x016361c8, const unsigned short * *
0x00000000, unsigned int 0x00000000, nsIURI * 0x0342b378, const nsString &
{???}, unsigned int 0x00000000, unsigned int 0x00000000, unsigned int
0x00000001, const char * 0x016361e0) line 2332 + 25 bytes
logMessage(nsIContent * 0x0362b1c8, const nsAString_internal & {...}, int
0x00000001, const char * 0x016361c8) line 163 + 107 bytes
RectArea::ParseCoords(const nsAString_internal & {...}) line 415 + 30 bytes
nsImageMap::AddArea(nsIContent * 0x0362b1c8) line 908
nsImageMap::UpdateAreas() line 850
nsImageMap::Init(nsIPresShell * 0x0335f1a0, nsIFrame * 0x035b1c90,
nsIDOMHTMLMapElement * 0x0362af74) line 799 + 8 bytes
nsImageFrame::GetImageMap(nsPresContext * 0x0345d4d8) line 1521
nsImageFrame::Paint(nsImageFrame * const 0x035b1c90, nsPresContext * 0x0345d4d8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11700 height=2070},
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 1408
+ 12 bytes
nsContainerFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11700 height=2070}, nsIFrame * 0x035b1c90,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 283
nsBlockFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11700 height=2070}, nsIFrame * 0x035b1c90,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 287
PaintLine(const nsRect & {x=0 y=0 width=11700 height=2070}, const nsRect & {x=0
y=0 width=11700 height=2070}, nsLineList_iterator & {...}, int 0x00000000, int &
0x035b1910, nsPresContext * 0x0345d4d8, nsIRenderingContext & {...},
nsFramePaintLayer eFramePaintLayer_Underlay, nsBlockFrame * 0x035b1910) line 6355
nsBlockFrame::PaintChildren(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11700 height=2070}, nsFramePaintLayer
eFramePaintLayer_Underlay, unsigned int 0x00000000) line 6423 + 44 bytes
nsHTMLContainerFrame::PaintDecorationsAndChildren(nsPresContext * 0x0345d4d8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11700 height=2070},
nsFramePaintLayer eFramePaintLayer_Underlay, int 0x00000001, unsigned int
0x00000000) line 138
nsBlockFrame::Paint(nsBlockFrame * const 0x035b1910, nsPresContext * 0x0345d4d8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11700 height=2070},
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 6250
nsContainerFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11700 height=2070}, nsIFrame * 0x035b1910,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 283
nsContainerFrame::PaintChildren(nsPresContext * 0x0345d4d8, nsIRenderingContext
& {...}, const nsRect & {x=0 y=0 width=11700 height=2070}, nsFramePaintLayer
eFramePaintLayer_Underlay, unsigned int 0x00000000) line 228
nsTableCellFrame::Paint(nsTableCellFrame * const 0x035b18b0, nsPresContext *
0x0345d4d8, nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11700
height=2070}, nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int
0x00000000) line 440
nsContainerFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11700 height=2070}, nsIFrame * 0x035b18b0,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000001) line 283
nsContainerFrame::PaintChildren(nsPresContext * 0x0345d4d8, nsIRenderingContext
& {...}, const nsRect & {x=0 y=0 width=11700 height=2070}, nsFramePaintLayer
eFramePaintLayer_Underlay, unsigned int 0x00000001) line 228
nsTableRowFrame::Paint(nsTableRowFrame * const 0x035b16ec, nsPresContext *
0x0345d4d8, nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11700
height=2070}, nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int
0x00000001) line 561
nsContainerFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11700 height=8235}, nsIFrame * 0x035b16ec,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000001) line 283
nsContainerFrame::PaintChildren(nsPresContext * 0x0345d4d8, nsIRenderingContext
& {...}, const nsRect & {x=0 y=0 width=11700 height=8235}, nsFramePaintLayer
eFramePaintLayer_Underlay, unsigned int 0x00000001) line 228
nsTableRowGroupFrame::Paint(nsTableRowGroupFrame * const 0x035fe6b8,
nsPresContext * 0x0345d4d8, nsIRenderingContext & {...}, const nsRect & {x=0 y=0
width=11700 height=8235}, nsFramePaintLayer eFramePaintLayer_Underlay, unsigned
int 0x00000001) line 229
nsContainerFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11700 height=8235}, nsIFrame * 0x035fe6b8,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000001) line 283
nsContainerFrame::PaintChildren(nsPresContext * 0x0345d4d8, nsIRenderingContext
& {...}, const nsRect & {x=0 y=0 width=11700 height=8235}, nsFramePaintLayer
eFramePaintLayer_Underlay, unsigned int 0x00000001) line 228
nsTableFrame::PaintChildren(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11700 height=8235}, nsFramePaintLayer
eFramePaintLayer_Underlay, unsigned int 0x00000001) line 1357
nsTableFrame::Paint(nsTableFrame * const 0x035b138c, nsPresContext * 0x0345d4d8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11700 height=8235},
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000001) line 1419
nsContainerFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11700 height=8235}, nsIFrame * 0x035b138c,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 283
nsTableOuterFrame::Paint(nsTableOuterFrame * const 0x035b1230, nsPresContext *
0x0345d4d8, nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11700
height=8235}, nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int
0x00000000) line 335
nsContainerFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11715 height=8235}, nsIFrame * 0x035b1230,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 283
nsBlockFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11715 height=8235}, nsIFrame * 0x035b1230,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 287
PaintLine(const nsRect & {x=0 y=0 width=11700 height=15120}, const nsRect & {x=0
y=0 width=11715 height=8235}, nsLineList_iterator & {...}, int 0x00000000, int &
0x035eb214, nsPresContext * 0x0345d4d8, nsIRenderingContext & {...},
nsFramePaintLayer eFramePaintLayer_Underlay, nsBlockFrame * 0x035eb404) line 6355
nsBlockFrame::PaintChildren(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11715 height=8235}, nsFramePaintLayer
eFramePaintLayer_Underlay, unsigned int 0x00000000) line 6423 + 44 bytes
nsHTMLContainerFrame::PaintDecorationsAndChildren(nsPresContext * 0x0345d4d8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11715 height=8235},
nsFramePaintLayer eFramePaintLayer_Underlay, int 0x00000001, unsigned int
0x00000000) line 138
nsBlockFrame::Paint(nsBlockFrame * const 0x035eb404, nsPresContext * 0x0345d4d8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11715 height=8235},
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 6250
nsContainerFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11715 height=8235}, nsIFrame * 0x035eb404,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 283
nsBlockFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11715 height=8235}, nsIFrame * 0x035eb404,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 287
PaintLine(const nsRect & {x=0 y=0 width=12360 height=15120}, const nsRect & {x=0
y=0 width=11715 height=8235}, nsLineList_iterator & {...}, int 0x00000000, int &
0x035fe4f4, nsPresContext * 0x0345d4d8, nsIRenderingContext & {...},
nsFramePaintLayer eFramePaintLayer_Underlay, nsBlockFrame * 0x035eb28c) line 6355
nsBlockFrame::PaintChildren(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11715 height=8235}, nsFramePaintLayer
eFramePaintLayer_Underlay, unsigned int 0x00000000) line 6423 + 44 bytes
nsHTMLContainerFrame::PaintDecorationsAndChildren(nsPresContext * 0x0345d4d8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11715 height=8235},
nsFramePaintLayer eFramePaintLayer_Underlay, int 0x00000001, unsigned int
0x00000000) line 138
nsBlockFrame::Paint(nsBlockFrame * const 0x035eb28c, nsPresContext * 0x0345d4d8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11715 height=8235},
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 6250
nsContainerFrame::PaintChild(nsPresContext * 0x0345d4d8, nsIRenderingContext &
{...}, const nsRect & {x=0 y=0 width=11715 height=8235}, nsIFrame * 0x035eb28c,
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 283
nsContainerFrame::PaintChildren(nsPresContext * 0x0345d4d8, nsIRenderingContext
& {...}, const nsRect & {x=0 y=0 width=11715 height=8235}, nsFramePaintLayer
eFramePaintLayer_Underlay, unsigned int 0x00000000) line 228
nsHTMLContainerFrame::Paint(nsHTMLContainerFrame * const 0x035fe0d8,
nsPresContext * 0x0345d4d8, nsIRenderingContext & {...}, const nsRect & {x=0 y=0
width=11715 height=8235}, nsFramePaintLayer eFramePaintLayer_Underlay, unsigned
int 0x00000000) line 84
CanvasFrame::Paint(CanvasFrame * const 0x035fe0d8, nsPresContext * 0x0345d4d8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11715 height=8235},
nsFramePaintLayer eFramePaintLayer_Underlay, unsigned int 0x00000000) line 369 +
27 bytes
PresShell::Paint(PresShell * const 0x0335f218, nsIView * 0x0360ccd8,
nsIRenderingContext & {...}, const nsRect & {x=0 y=0 width=11715 height=8235})
line 5639 + 31 bytes
nsView::Paint(nsView * const 0x0360ccd8, nsIRenderingContext & {...}, const
nsRect & {x=0 y=0 width=11715 height=8235}, unsigned int 0x00000000, int &
0x00000000) line 316
nsViewManager::RenderDisplayListElement(DisplayListElement2 * 0x0363f050,
nsIRenderingContext * 0x036dbf70) line 1468
nsViewManager::RenderViews(nsView * 0x0314ebd0, nsIRenderingContext & {...},
const nsRegion & {...}, nsIDrawingSurface * 0x036d9100, const nsVoidArray &
{...}) line 1380
nsViewManager::Refresh(nsView * 0x0314ebd0, nsIRenderingContext * 0x036dbf70,
nsIRegion * 0x034cdf58, unsigned int 0x00000001) line 930
nsViewManager::DispatchEvent(nsViewManager * const 0x0345ed38, nsGUIEvent *
0x0012f6f8, nsEventStatus * 0x0012f5dc) line 2055
HandleEvent(nsGUIEvent * 0x0012f6f8) line 174
nsWindow::DispatchEvent(nsWindow * const 0x0360cb3c, nsGUIEvent * 0x0012f6f8,
nsEventStatus & nsEventStatus_eIgnore) line 1062 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012f6f8, nsEventStatus &
nsEventStatus_eIgnore) line 1088
nsWindow::OnPaint(HDC__ * 0x00000000) line 5589 + 28 bytes
nsWindow::ProcessMessage(unsigned int 0x0000000f, unsigned int 0x00000000, long
0x00000000, long * 0x0012fc04) line 4203 + 19 bytes
nsWindow::WindowProc(HWND__ * 0x003c0b2e, unsigned int 0x0000000f, unsigned int
0x00000000, long 0x00000000) line 1251 + 27 bytes
USER32! 77d48654()
USER32! 77d48723()
USER32! 77d49153()
USER32! 77d49196()
NTDLL! 77f75da3()
USER32! 77d48a12()
nsAppStartup::Run(nsAppStartup * const 0x01d92b90) line 208
main1(int 0x00000001, char * * 0x002a2d50, nsISupports * 0x00a58e38) line 1249 +
32 bytes
main(int 0x00000001, char * * 0x002a2d50) line 1738 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e

Comment 4

[Simon Montagu :smontagu]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsImageMap.cpp&rev=3.114&mark=154,155#142

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 196170 [details] [diff] [review]
v1

r+sr=jst