307269 - remove unnecessary |memset| in |nsSaveMsgListener::OnDataAvailable|

Status: VERIFIED FIXED

(MailNews Core :: Attachments, defect)

Description

[Hans-Andreas Engel]

In |nsSaveMsgListener::OnDataAvailable|, 
|m_dataBuffer| is filled with |readCount| bytes and then either
  |Substring(m_dataBuffer, m_dataBuffer + readCount)|  or
  |m_outputStream->Write(m_dataBuffer, readCount, ...)|
is invoked.  Thus, the initial value of |m_dataBuffer[readCount]| is irrelevant.

However, it is initialized a few lines above via |memset|, 
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/src/nsMessenger.cpp&rev=1.322#2117
This initialization is unnecessary and should be removed.

Comment 1

[Hans-Andreas Engel]

Attachment: remove inovocation of |memset|

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 195066 [details] [diff] [review]
remove inovocation of |memset|

I'd rather not review mailnews code... try a mailnews peer such as bienvenu,
mscott or dmose.

Comment 3

[Hans-Andreas Engel]

Comment on attachment 195066 [details] [diff] [review]
remove inovocation of |memset|

cbiesinger: Thank you for your quick response! (I saw that you recently worked
on nsMessenger.cpp and also review several patched on it.)

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, almost all of those were tree-wide changes.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Checked in by timeless at 2005-09-25 18:38 PDT.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-09-26-06 Windows XP SeaMonkey trunk on
nightshade.uits.indiana.edu Cyrus IMAP4 Murder v2.2.10.

No problems with IMAP seen thus far.