307270 - displayed URLs when no product is given in editcomponents.cgi are wrong

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

admin/components/select-product.html.tmpl uses the following URL:

[% bug_count_contentlink = BLOCK %]buglist.cgi?component=%%name%%&product=
  [%- product FILTER url_quote %][% END %]

It should clearly be:

[% bug_count_contentlink = BLOCK %]buglist.cgi?product=%%name%%[% END %]


Other admin/*/select-product.html.tmpl files have this bug too, but these links
are never displayed. For these files, either 'showbugcounts=1' should be
available, or this unused code should be removed.

Comment 1

[Frédéric Buclin]

Attachment: patch for 2.20, v1

This patch is for 2.20 only. The blocker will fix for 2.22.

Comment 2

[GavinS]

Comment on attachment 195763 [details] [diff] [review]
patch for 2.20, v1

Yes, OK. It would be nice to remove the redundant code from the other
select-product pages, but not now

Comment 3

[Frédéric Buclin]

2.20 only:

Checking in template/en/default/admin/components/select-product.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/select-product.html.tmpl,v
 <--  select-product.html.tmpl
new revision: 1.1.8.1; previous revision: 1.1
done