307310 - crash [@ nsAbout::NewChannel]

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[timeless]

R:\mozilla\opt71-i686-pc-cygwin\dist\bin>TestProtocols.exe about:
!!! XPConnect won't warn about Shadowed Members of...
   Window, HTMLInputElement, HTMLDocument, HTMLCollection, Event, ChromeWindow

-	tempChannel	{...}	nsCOMPtr<nsIChannel>
+	nsCOMPtr_base	{mRawPtr=0x00000000 }	nsCOMPtr_base

>	appshell.dll!nsAbout::NewChannel(nsIURI * aURI=0x00b18f00, nsIChannel * 
* result=0x0012fe88)  Line 75 + 0x6	C++
 	necko.dll!nsAboutProtocolHandler::NewChannel(nsIURI * uri=0x00b18f00, 
nsIChannel * * result=0x0012fe88)  Line 163 + 0xd	C++
 	necko.dll!nsIOService::NewChannelFromURI(nsIURI * aURI=0x10046d58, 
nsIChannel * * result=0x00c6e8b0)  Line 494 + 0xf	C++
 	TestProtocols.exe!NS_NewChannel(nsIChannel * * result=0x0012ff30, 
nsIURI * uri=0x00b18f00, nsIIOService * ioService=0x00a98ce0, nsILoadGroup * 
loadGroup=0x00000000, nsIInterfaceRequestor * callbacks=0x00aa5548, unsigned 
int loadFlags=0)  Line 171 + 0xe	C++
 	TestProtocols.exe!StartLoadingURL(const char * aUrlString=0x00c6e8b0)  
Line 636 + 0x19	C++
 	TestProtocols.exe!main(int argc=2, char * * argv=0x00366a80)  Line 837 
+ 0x7	C++
 	TestProtocols.exe!mainCRTStartup()  Line 398 + 0xe	C
 	kernel32.dll!_BaseProcessStart@4()  + 0x23

Comment 1

[Bastiaan Jacques]

Attachment: fix

So.. why did you file this in networking, timeless?

Comment 2

[[e-mail]]

Comment on attachment 196334 [details] [diff] [review]
fix

Sorry, I don't understand this bug.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Un-bitrotted fix

Un-bitrotted fix. Carrying over timeless' earlier review.

Comment 4

[Reed Loden [:reed]]

Checking in xpfe/appshell/src/nsAbout.cpp;
/cvsroot/mozilla/xpfe/appshell/src/nsAbout.cpp,v  <--  nsAbout.cpp
new revision: 1.23; previous revision: 1.22
done