Large View Icons (Day View, Week View, etc.) don't have a clear pressed state in Win XP Luna default theme

VERIFIED FIXED in Sunbird 0.3

Status

--
minor
VERIFIED FIXED
13 years ago
13 years ago

People

(Reporter: sipaq, Assigned: Mark)

Tracking

Trunk
Sunbird 0.3
x86
Windows XP

Details

Attachments

(5 attachments)

(Reporter)

Description

13 years ago
Our large View Icons have a variety of problems on WinXP Luna in their pressed
state (see 1st attached screenshot). It is not easy to find out, which is the
current view mode by looking at the Icon toolbar.

1. In Icons+Text mode, we just distinguish the active view by greying out the
button text and by placing the icon one or two pixels below the other view icons
(which looks pretty ugly by the way).

2. In Icons mode, we just distinguish the active view placing the icon one or
two pixels below the other view icons. Here it is especially hard to determine
which is the active view.

3. In Text mode we distinguish the active view by greying out the button text
and by placing the icon one or two pixels below the other view icons. Here it
looks even more ugly than in Icons+Text mode.


In small icons mode, it is a bit better. The active state of the view icons
looks different than the inactive icons by having the inner calendar color by
white (see 2nd screenshot).


I would propose to mimic what Firefox does here (Bookmarks or History icon - see
3rd screenshot) for small icons mode and combine the Firefox approach with our
small icons approach for the big icons mode.
(Reporter)

Comment 1

13 years ago
Created attachment 195126 [details]
Large View Icons in Luna and Classic
(Reporter)

Comment 2

13 years ago
Created attachment 195127 [details]
Small Icons in Luna
(Reporter)

Comment 3

13 years ago
Created attachment 195128 [details]
How Firefox handles this (Large Icons - Luna)
(Reporter)

Updated

13 years ago
Target Milestone: --- → Sunbird 0.3
(Reporter)

Comment 4

13 years ago
Created attachment 195235 [details]
New large toolbar icons from Mark Carson

These are new large toolbar icons which mimic the disabled state of the small
toolbar icons for the view icons. IMO this is a definite improvement and we
should take them.
Attachment #195235 - Flags: first-review?(jminta)

Comment 5

13 years ago
Comment on attachment 195235 [details]
New large toolbar icons from Mark Carson

Yeah, I like the brighter active icons.  Just to be clear, those were the only
changes?

r=jminta
Attachment #195235 - Flags: first-review?(jminta) → first-review+

Comment 6

13 years ago
Comment on attachment 195235 [details]
New large toolbar icons from Mark Carson

Beltzner knows more about reviewing this sort of thing.
Attachment #195235 - Flags: second-review?(mike)
(Assignee)

Comment 7

13 years ago
Yes, the only changes to the toolbar-large.png set of packed (24x24) icons is
the 4 active View icons which now have a solid white background in place of the
blue-ish gradient. Icons alignments, ordering, etc. all remain the same, so this
.PNG can be dropped in place of the existing toolbar-large.png image in the
calendar.jar.
Comment on attachment 195235 [details]
New large toolbar icons from Mark Carson

Looks good to me as a makes-it-workable without boiling the ocean for 0.3.
Eventually I think we'll want to revisit the colour scheme and overall
appearance of selected vs. unselected icons, but there's no need to do it
immediately.
Attachment #195235 - Flags: second-review?(mike) → second-review+
toolbar-large-0.3.png: PNG image data, 478 x 94, 8-bit/color RGBA, non-interlaced
toolbar-large.png:     PNG image data, 480 x 96, 8-bit/color RGBA, interlaced

The original and the new images are not of the same size. Visual inspection
seems to show the the left (blank) pixels are missing. I think that will make
all the clip rects wrong, because the icons now live on a new offset in the image.
Mark, can you provide a new image of the same size? (or show that i'm wrong)
(Assignee)

Comment 10

13 years ago
Created attachment 195782 [details]
Sunbird Large Toolbar - correctly dimensioned

Left and bottom padding now corrected (thanks MVL).
Image checked in.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Reporter)

Comment 12

13 years ago
verified fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.