307347 - nsSchemaLoader needs to take ns:name into account for ref=""

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Doron Rosenberg (IBM)]

There are still several places that use ref="" without taking ns:name into account.

Comment 1

[Doron Rosenberg (IBM)]

Attachment: patch

This fixes all ref="" users.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 195144 [details] [diff] [review]
patch

>Index: extensions/webservices/schema/src/nsSchemaLoader.cpp
>===================================================================

>@@ -2809,25 +2791,28 @@ nsSchemaLoader::ProcessAttribute(nsIWebS

>+    nsresult rv = ParseNameAndNS(ref, aElement, ref, refNS);

Don't redeclare rv.

>@@ -2911,26 +2896,31 @@ nsSchemaLoader::ProcessAttribute(nsIWebS
> nsresult 
> nsSchemaLoader::ProcessAttributeGroup(nsIWebServiceErrorHandler* aErrorHandler,
>                                       nsSchema* aSchema, 
>                                       nsIDOMElement* aElement,
>                                       nsISchemaAttributeGroup** aAttributeGroup)
> {
>   nsresult rv;

>+    nsresult rv = ParseNameAndNS(ref, aElement, ref, refNS);

Don't redeclare rv.

>Index: extensions/webservices/schema/src/nsSchemaParticles.cpp
>===================================================================

>@@ -305,21 +306,31 @@ NS_IMETHODIMP

>+    // use the namespace and type
>+    nsCOMPtr<nsISchemaCollection> schemaColl;
>+    mSchema->GetCollection(getter_AddRefs(schemaColl));
>+    NS_ENSURE_STATE(schemaColl);
>+
>+    // get the right schema
>+    nsCOMPtr<nsISchema> schema;
>+    schemaColl->GetSchema(mRefNS, getter_AddRefs(schema));
>+    NS_ENSURE_STATE(schema);
>+
>+    schema->GetModelGroupByName(mRef, getter_AddRefs(mModelGroup));

Shortcut to |mSchema->GetModelGroupByName(mRef, getter_AddRefs(mModelGroup));|
when mRefNS is empty?

Comment 3

[Doron Rosenberg (IBM)]

checked into trunk

Comment 4

[Doron Rosenberg (IBM)]

Comment on attachment 195144 [details] [diff] [review]
patch

No regressions, asking for 1.8b5, needed for XForms and probably also fixes
some broken web services..

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 195144 [details] [diff] [review]
patch

can you tell us more about the risk here ?

Comment 6

[Doron Rosenberg (IBM)]

This code is only used by web services, and I checked existing ones and they
still worked.

There should be no risk here since this code isn't used a lot.

Comment 7

[Doron Rosenberg (IBM)]

checked into trunk