307357 - newly-opened window slightly less wide than previously-closed window

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[web]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

If the last browser window is closed when its width is near or exactly the
maximum allowed, the next window opened will have a width that is a few pixels
less.  The location of the left-hand side appears to be the same, but the right
side is a few pixels further left.  

This is important because users often push their mouse cursor to the right edge
of the screen to reach the scrollbar (without looking at it).  If they then
click to scroll, they will instead activate the application or desktop behind
Firefox, since the browser window does not reach to the right edge of the
screen.  The naive response is to return to Firefox and resize the browser
window by dragging the resize handle to the right edge of the screen.  Because,
however, the left edge of the window doesn't move, this returns the window to
near (or equal) its maximum width, meaning that the gap will reappear the next
time a browser window is opened (or when Firefox is restarted).  Unless the user
realizes that the window must be dragged slightly to the right instead of
resized, they will need to resize every window opened by the browser.

Reproducible: Always

Steps to Reproduce:
0. Ensure that only one browser window is open.
1. Drag the left edge of the browser window to (or a few pixels beyond) the left
edge of the screen.
2. Resize the browser window by dragging the resize handle as far right as it
will go (i.e. the right edge of the screen.
3. Make sure that there is no gap between the right edge of the window and the
right edge of the screen by checking that clicking with a mouse cursor at the
right edge of the screen activates the scroll bar (not the window or desktop
behind firefox).
4. Close the browser window.
5. Open a new browser window.
Actual Results:  
The new window is slightly thinner than the previously closed browser window
(i.e. doesn't extend to the right edge of the screen).

Expected Results:  
The new window should have the same width as the previously closed one, with no
gap between its right edge and the right edge of the screen.

Comment 1

[Josh Aas]

WFM, neither me nor Mark Mentovai can repro

Comment 2

[web]

Attachment: The original window which extends to the right edge of the screen.

Comment 3

[web]

Attachment: Subsequent window with a gap (in green) at the right edge.

Comment 4

[Mark Mentovai]

I can't reproduce in 1.0.6, branch (to be 1.5), or trunk.  I can't reproduce
whether or not I've got my work-in-progress resizing patch applied.  1.5b1 will
be available soon - perhaps today, even - would you mind retesting with that and
a fresh profile?

Comment 5

[web]

It appears that the bug only occurs if my Dock is positioned on the left or right edge of the screen, but not 
if it's on the bottom.  Where are your Docks located?

BTW, this is Firefox 1.0.6 on Mac OS X 10.4 (Tiger).

I've attached two screenshots which illustrate the problem.  The first was taken after launching Firefox and 
stretching the window to the right edge of the screen.  It is the only Firefox window open. 

Between the two screenshots, I pressed only Command-W and Command-N, which resulted in the window 
shown in the second attachment.  As you can see, there is a small green strip of my desktop visible at the 
right. 

Comment 6

[Mark Mentovai]

OK, that's it.  My docks are on the bottom edge.  I can see this when I move
them to the sides.

When we figure out the usable desktop area, we're supposed to not count the area
used for the dock.  (It doesn't really work properly in fox 1.0 or even on the
trunk and 1.8 branch right now - this is something I'm working on.)  Even when
the dock is hidden, the system reserves 4px for the dock along the edge it's
positioned on.  That area is removed from the usable area.  When you open a
fresh window, it's being positioned so that it fits in the usable area.  That's
where the strip comes from.

I'm taking this for myself, but the resolution won't be clean.  (Nothing about
fixing up resizing is.)  The best solution might be to ignore docks that are too
short or narrow when computing the available desktop size - anything less than
10px, for example.

Comment 7

[:Gijs (he/him)]

This now works! Marking as WFM... :-)