307395 - Default theme - 'Use this theme' is dimmed..

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4

Open the Theme Manager
Select the 'Default' theme...note that: 'Use this theme' is dimmed giving the
impression that you cannot select this theme.  Highlighting the derfault and
close/restart Firefox the Default is selected even though it was not clicked to
'Use this theme'.

Reproducible: Always

Steps to Reproduce:
1. Tools->Themes
2. Select Default theme
3. Note that 'use this theme is dimmed'
4. Close and restart Firefox 'Default' theme is now used even thought you could
not select 'Use this theme'
Actual Results:  
Default theme activated when not selected.

Expected Results:  
Should not change themes on close/restart
Should have the button 'Use this thieme' enabled.

Comment 1

[Robert Strong (they/them - no direct email)]

The button should only be disabled in this case if the default theme is already
in use and from the steps you provided it is not clear whether this is the case.
If it is you shouldn't be able to select use theme for a theme that is already
used. If it isn't the case can you also provide the additional steps to
reproduce since a default install will be using the default theme and hence the
button should be disabled.

Comment 2

[Robert Strong (they/them - no direct email)]

What appears to be happening is the attribute selected is being set on the
default theme even when it is not the theme seleted to be used. Confirmed on
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050906 Firefox/1.4
ID:2005090619

I'll try to take a look at this later tonight if someone doesn't beat me to it.

Comment 3

[Robert Strong (they/them - no direct email)]

This is now WFM with current builds.... Jim, can you confirm?

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

Thanks Robert, I have not been able to reproduce this, so WFM also.