307400 - Scrolling profiles in Profile Manager broken on other than English build when there are 6 profiles

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Ville Pohjanheimo (inactive)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fi; rv:1.8b4) Gecko/20050906 Firefox/1.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fi; rv:1.8b4) Gecko/20050906 Firefox/1.4

When there are 6 or more profiles, or enough profiles to warrant a scroll bar,
the Finnish Firefox's profile manager's scroll bar won't work. Trying to move
the scroll bar doesn't have any effect. Trying to move in the list with the
keyboard doesn't change the view either.

Tested on 6.9. Linux build and a couple of days older Windows build.

Reproducible: Always

Steps to Reproduce:

1. Create 5 or more profiles
2. Try to scroll the list of profiles


Actual Results:  
Scrolling won't work

Expected Results:  
Scrolling through the list should work.

Comment 1

[Ville Pohjanheimo (inactive)]

Forgot to mention the same is reported to work OK with the Swedish build.

Comment 2

[Alexander L. Slovesnik]

It affects also Russian Firefox (we've got a bunch of complaints on our forum).

Comment 3

[u60234]

It seems to depend on the length of the checkbox labels, offlineState.label and
autoSelect.label in profileSelection.dtd. The scrolling breaks if both labels
are so long that they wrap.

Comment 4

[HARUNAGA Hirotoshi]

Yes, Japanese localized build uses a workaround on intl.css like as
follows for the moment:
  #autoSelectLastProfile {
    white-space: nowrap;
  }

Comment 5

[HARUNAGA Hirotoshi]

changing the summary and adding intl and l12y keywords for the moment.

Comment 6

[Simon Montagu :smontagu]

Attachment: Patch

Comment 7

[Philipp Bönhof]

Please set version to 1.5.0.x. This problem occurs also in

Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4

which is the version of Firefox I am using.

I did the change to "toolkit/profile/content/profileSelection.xul" described in the patch (which tells us to remove a 'flex="1"' at the right position).
First I had to find out where the file was. For Windows users it is actually in "<installation folder of firefox>\chrome\toolkit.jar" if you open it in a zip-program (I used 7-Zip) you go to "content\mozapps\profile".

1. Close any running Firefox!
2. Make a backup of toolkit.jar before doing something with it!
3. Open "toolkit.jar" and browse to "profileSelection.xul" directly in the zip-program and changed it.
4. After saving and closing the editor 7-Zip asks if you want to store the changes into the archive: say yes.
5. Close zip-program, run Firefox and it should work.

At least it worked for me.

Comment 8

[Simon Montagu :smontagu]

Comment on attachment 224686 [details] [diff] [review]
Patch

load-balancing review requests

Comment 9

[Philipp Bönhof]

The only thing I remarked now as Firefox was updated, I had to redo the whole thing I described earlier.

Comment 10

[Asaf Romano (gone)]

Comment on attachment 224686 [details] [diff] [review]
Patch

r=mano.

Comment 11

[Simon Montagu :smontagu]

Fixed on trunk.

Comment 12

[Philipp Bönhof]

The bug is again present in 2.0.

At least in

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1) Gecko/20061010 Firefox/2.0

Can any body confirm for other systems?

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 224686 [details] [diff] [review]
Patch

approved for 1.8 branch, a=dveditz for drivers

Comment 14

[Simon Montagu :smontagu]

Checked in to 1.8 branch

Comment 15

[Rob Campbell [:rc] (:robcee)]

verified fixed in firefox-fi, win32, 2006120303