Closed Bug 307402 Opened 19 years ago Closed 11 years ago

include bug's summary with email address in mailto URI

Categories

(Bugzilla :: Creating/Changing Bugs, enhancement)

2.21
enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: wsmwk, Assigned: selsky)

Details

Attachments

(1 file, 3 obsolete files)

whenever I click an address I want some or all of the subject to be from summary
of the bug being displayed

1. view a bug
2. left click a bug address to initiate a new email

desired result - message with the subject already filled in with bug summary 
(help save the world from carpal tunnel)

eg  x@y?subject=include bug summary with email address in mailto URI
Sounds like a pretty good idea to me. :-)
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.24
Version: unspecified → 2.21
Whiteboard: [Good Intro Bug]
We are freezing the code for 3.0 in two weeks and we don't expect this bug to be fixed on time.
Target Milestone: Bugzilla 3.0 → ---
Here's what I found in the \bugzilla-3.0.3\template\en\default\request\email.txt.tmpl file:

From: [% Param('mailfrom') %]
To: [% to %]
Subject: [% flag.type.name %] [%+ subject_status %]: [[% terms.Bug %] [%+ bug.bug_id %]] [% bug.short_desc %]
[%- IF attachment %] :
  [Attachment [% attachment.id %]] [% attachment.description %][% END %]
X-Bugzilla-Type: request

Has this bug already been fixed?  In the subject line above it would seem we area extracting the bug, it's id and short desription already.  Should the issue be closed?  Let me know.

Best,

Mike
(In reply to comment #3)
> Here's what I found in the
> \bugzilla-3.0.3\template\en\default\request\email.txt.tmpl file:
> From: [% Param('mailfrom') %]
> To: [% to %]
> Subject: [% flag.type.name %] [%+ subject_status %]: [[% terms.Bug %] [%+
> bug.bug_id %]] [% bug.short_desc %]
> [%- IF attachment %] :
>   [Attachment [% attachment.id %]] [% attachment.description %][% END %]
> X-Bugzilla-Type: request
> Has this bug already been fixed?  In the subject line above it would seem we
> area extracting the bug, it's id and short desription already.  Should the
> issue be closed?  Let me know.
> Best,
> Mike

I'm trying to send myself an email here to check if this is already a closed issue, i.e., do I get the info in the subject line or not? :)
Attached patch Done for showbugs, not for attachments (obsolete) β€” β€” Splinter Review
Not sure what to do for the attachments. Should the default subject be the attachment description or the bug summary?
Attachment #356675 - Flags: review?(mkanat)
What would happen if short_desc says:

  Bug description&?bcc=user@example.com

?

Shouldln't we escape question marks, quotes, spaces?
Attachment #356675 - Attachment is obsolete: true
Attachment #356675 - Flags: review?(mkanat)
Attached patch added FILTER html (obsolete) β€” β€” Splinter Review
Attachment #356684 - Flags: review?(mkanat)
http://www.bugzilla.org/docs/developer.html#templates-html

| When URIs appear in HTML, the html filter is not enough to properly escape 
| strings into the format that can appear in a URI.

Perhaps 'url_quote' is more suitable than 'html'
Attachment #356684 - Attachment is obsolete: true
Attachment #356684 - Flags: review?(mkanat)
Attached patch used url_quote instead of html (obsolete) β€” β€” Splinter Review
Attachment #356728 - Flags: review?(vitaly.fedrushkov)
Attachment #356728 - Flags: review?(vitaly.fedrushkov) → review?(mkanat)
Comment on attachment 356728 [details] [diff] [review]
used url_quote instead of html

Hmm, will this brake the hCard, though?
Comment on attachment 356728 [details] [diff] [review]
used url_quote instead of html

bitrot
Attachment #356728 - Flags: review?(mkanat) → review-
Update for bitrot.
Assignee: create-and-change → selsky
Attachment #356728 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #588947 - Flags: review?(LpSolit)
http://hcard.geekhood.net/ confirms that the hCard data still validates correctly (without the subject in the mailto).
Comment on attachment 588947 [details] [diff] [review]
Add bug summary to mailto link, v1

>+      <a class="email" href="mailto:[% who.email FILTER html %]?subject=[% bug.short_desc FILTER uri %]"

What annoys me with this patch is that this is going to make the page size much larger as we are going to duplicate the bug summary N times, where N is the number of comments in the bug. Some bugs have 100+ comments!

I would prefer some JS code which catch a click on the commenter's email address and append "?subject=[% bug.short_desc FILTER uri %]" itself before passing it to the email client. Users with JS turned off would still get the current behavior, so it degrades gracefully.
Attachment #588947 - Flags: review?(LpSolit) → review-
I'll take a look at the JS code.

But won't pages be gzip-compressed by the web server such that the repeated data won't be a problem?
Whiteboard: [Good Intro Bug] → [good first bug][lang=perl]
i don't agree that this is a good idea.

it breaks the workflow of copying a mailto: link to grab the login to paste elsewhere in bugzilla (a task i perform on a nearly daily basis).
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Whiteboard: [good first bug][lang=perl]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: