307411 - Can't add spaces or separators to toolbar

Status: RESOLVED FIXED

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[jrx]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050907 Mozilla Sunbird/0.2+

The Sunbird toolbar can be customized but spaces, flexible spaces, and
separators cannot be added or moved around.

Reproducible: Always

Steps to Reproduce:
1.Right-click on toolbar, select "Customize..."
2.Try to add a space or separator
3.

Actual Results:  
Nothing

Expected Results:  
Added a space

Comment 1

[Joey Minta]

Confirmed.  This worked previously though.  Can someone give me a regression
window?  Probably around bug 306693?

Status: NEW

Comment 2

[jrx]

It worked in the 20050901 Windows build, but did not in the 20050906 build (the
next one that was released).  

Comment 3

[Simon Paquet [:sipaq]]

This also happens in a Firefox trunk build from 2005-09-07 (branch is fine), 
so it is not a Sunbird but a Toolkit issue. Since I couldn't find any likely 
culprits in the Toolkit checkins of last week, it might be that a layout fix 
was responsible for this.

Boris, any idea whether this is a layout issue?
Regression window is between 2005-09-01 and 2005-09-06 on the trunk.

Comment 4

[Ria Klaassen (not reading all bugmail)]

Adding a separator from the customize window to the toolbar still worked in
1.9a1_2005090513 but failed in 1.9a1_2005090522.

Comment 5

[Simon Paquet [:sipaq]]

Thanks Ria, that reduces the set of likely culprits to the following bugs:

Bug 306262 - Don't condition selection on whether we're in a chrome docshell;
explicitly disable selection for <label> and <description> as needed.

Bug 306660 - Make addition or removal of frames in a frameset actually change
the rendering.

Bug 306116 - Use a loop instead of recursion while deleting next-in-flows to
avoid stack overflow when reflowing really long text.

Bug 248407 - Ensure thumb frame exists

I'm not a layout expert, but Bug 306262 looks most suspicious to me.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Should retest once bug 307256 is fixed

Comment 7

[Phil Ringnalda (:philor)]

*** Bug 308043 has been marked as a duplicate of this bug. ***

Comment 8

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050911 Firefox/1.6a1
ID:2005091112

This WFM now after the checkin for bug 307256.