307412 - other dialogs don't open from options dialog when options dialog is opened from startmenu

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Erik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4

When I open the option dialog from the start menu, right clicking on firefox
icon and press a button which should open another dialog ( ex 'view Cookies' )
those dialogs don't open.
It doesn't metter if firefox is open or not.

Firefox is added to the startmenu because it is my default browser. I supose the
menu is not visible when it is in the most commonly used list or in 'all
programs' part of the menu

Reproducible: Always

Steps to Reproduce:
1. Press Start
2. Right click on firefox icon
3. Choose 'Firefox Options'
4. Press a button which opens an other dialog (ex 'View Cookies')
Actual Results:  
Nothing happens

Expected Results:  
A dialog should open where you can view your cookies

Comment 1

[Adam Guthrie]

How you start Firefox shouldn't have anything to do with this... can you
reproduce this with a clean profile?

Comment 2

[Dave Townsend [:mossop]]

I can confirm this with a blank profile.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050907
Firefox/1.6a1 ID:2005090707

Comment 3

[Dave Townsend [:mossop]]

Not all sub-windows fail, but those that do seem to be those calling openWindow
(http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/preferences.xml#845).

Even the JavaScript options extension is affected here.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #1)
> How you start Firefox shouldn't have anything to do with this... can you
> reproduce this with a clean profile?

How you open Firefox is exactly what causes this bug :). Opening the prefs
dialog by right clicking the start menu shortcut is the same as |firefox.exe
-preferences|.

(In reply to comment #3)
> Not all sub-windows fail, but those that do seem to be those calling openWindow

Indeed, if the options dialog is opened via the start menu, there is no
"window.parent", so it fails if instantApply isn't enabled.

Comment 5

[Dave Townsend [:mossop]]

Attachment: Patch

This patch makes it fall back to opening with the prefwindow when the window
opener is non-existant or closed.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in toolkit/content/widgets/preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.34; previous revision: 1.33
done

Comment 7

[Scott MacGregor]

Comment on attachment 195880 [details] [diff] [review]
Patch

we should look into taking the patch for this 1.8b5 blocking bug if we can
verify that things work now on the trunk.

Comment 8

[Dave Townsend [:mossop]]

Fixed on trunk. Leaving open till branch checkin.

Comment 9

[Asa Dotzler [:asa]]

Please resolve bugs when you land them on the trunk. Without that status, the
bug won't get QA Verification attention and we don't want to take fixes until
they've been verified on the trunk. The approval request is enough to keep this
bug alive even after being verified on the trunk.

Comment 10

[Dave Townsend [:mossop]]

Ok, wasnt sure of the process.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

1.8 Branch:
mozilla/toolkit/content/widgets/preferences.xml; new revision: 1.31.2.3;