307423 - Asterisk (*) no longer Expands All Threads

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Ashley Bischoff (blog at handcoding.com)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050906 Firefox/1.6a1 (bangbang023)
Build Identifier: Thunderbird version 1.6a1 (20050907)

Expand All Threads has the hotkey "*"; that used to work but doesn't anymore.

Reproducible: Always

Steps to Reproduce:
1. View a mail folder which has threaded messages (such as your Bugzilla folder,
if you have one)
2. Make sure View -> Sort By -> Threaded is selected
3. Hit the asterisk.

Actual Results:  
Nothing

Expected Results:  
All threads are expanded :).

Selecting "Expand All Threads" through the menu still works (View -> Threads ->
Expand All Threads). 

Possibly in the same vicinity: bug 64426 (Expand All Threads to remember its
state), though that one isn't a recent regression.

Comment 1

[Mike Cowperthwaite]

What's the last version you ran where this worked?  I'm seeing it work OK with 
1.6a1-0904.

Comment 2

[Ashley Bischoff (blog at handcoding.com)]

(In reply to comment #1)
> What's the last version you ran where this worked?  I'm seeing it work OK with 
> 1.6a1-0904.

I'm not sure, off the top of my head, but I'll try progressively downgrading to
check on that.

Comment 3

[Ashley Bischoff (blog at handcoding.com)]

(In reply to comment #2)
> I'm not sure, off the top of my head, but I'll try progressively downgrading to
> check on that.

Mike: I downgraded from one nightly build to another until the bug disappeared.
Here're my findings:

* 2005-08-26-09 - Ok
* 2005-08-30-07 - Ok
* 2005-08-31-12 [X]
* 2005-09-01-09 [X]
* 2005-09-04-11 [X]
* 2005-09-05-09 [X]

I'm not sure what's going on with your 0904 build ;). Are you running the trunk
builds? Also, when you go into a folder with threaded messages, you may need to
manually contract a thread (with the "-" sign) before hitting the asterisk key
-- just so that there's a thread /to/ expand.

Comment 4

[Susanne Jaeger]

Same for SeaMonkey on Linux. 
It worked with 2005083009 and doesn't with 20050903.
I'm missing intermediate builds. 

Comment 5

[Hartmut Figge]

(In reply to comment #4)
> Same for SeaMonkey on Linux.

Yes.

> It worked with 2005083009 and doesn't with 20050903.
> I'm missing intermediate builds.

I have some. :)

The regression occured for my selfcompiled linux between
200508300919 and 200508310816 CEST

Comment 6

[Hartmut Figge]

(In reply to comment #5)

> The regression occured for my selfcompiled linux between
> 200508300919 and 200508310816 CEST

Hm, that could have been clearer a bit. The dates were taken immediately after
the CVS-update. And i should have given more information about my User-Agent.
Currently it is
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050910 SeaMonkey/1.1a

Comment 7

[Frank Wein [:mcsmurf]]

Checkins in regression timeframe (this also regressed in SeaMonkey btw), based
that it work in official 2005-08-30 06:00 builds and broke 2005-08-31 08:16 CEST:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-08-30+05%3A00%3A00&maxdate=2005-08-31+01%3A00%3A00&cvsroot=%2Fcvsroot

Comment 8

[Ashley Bischoff (blog at handcoding.com)]

OS -> All

(Since I'm seeing this on Win2k & XP, while others are seeing it on Linux.)

Comment 9

[Boris Zbarsky [:bzbarsky]]

Dainis, I think this is yours...

Comment 10

[Dainis Jonitis]

Attachment: Patch to fix accesskey problem (not verified)

This should fix the problem with "*", "\" and "-" acceskeys in Thunderbird.
Unfortunately I can not build the Thunderbird at the moment to verify it. I
would appreciate if someone else tries this.

Comment 11

[[e-mail]]

Comment on attachment 195717 [details] [diff] [review]
Patch to fix accesskey problem (not verified)

The new keys don't need ids. Also afaik this file doesn't need superreview.

Comment 12

[[e-mail]]

Attachment: Suite version (checked in)

Comment 13

[David :Bienvenu]

Comment on attachment 196140 [details] [diff] [review]
Suite version (checked in)

oops, clearing r+

Comment 14

[Scott MacGregor]

Comment on attachment 195717 [details] [diff] [review]
Patch to fix accesskey problem (not verified)

please remove the id's to the new keys which as Neil pointed out, I don't think
we need.

Comment 15

[Dainis Jonitis]

Attachment: Thunderbird patch without duplicate key IDs

Comment 16

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 196140 [details] [diff] [review]
Suite version (checked in)

First a=me.

Why is oncommand not properly indented?

Comment 17

[Ian Neal]

Comment on attachment 196140 [details] [diff] [review]
Suite version (checked in)

a=me for SM1.0b on SM only part of code, 2nd needed one - with indentation perhaps?

Comment 18

[[e-mail]]

SeaMonkey-only portion of patch checked in to the 1.8 branch.

Comment 19

[David :Bienvenu]

tb fix checked in.

Comment 20

[Scott MacGregor]

the thunderbird only portion is now also on the 1.8.1 branch for thunderbird 2.0