307455 - "Help Contents" menuitem is labeled "Firefox Help" on OS X

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect, P3)

Description

[Asaf Romano (gone)]

The "Help Contents" menuitem is labeled "Firefox Help" on OS X.

Comment 1

[Jo Hermans]

That's according to the Apple Human Interface Guidelines :
<http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_16_section_4.html#//apple_ref/doc/uid/TP30000356-TPXREF108>

"If your application provides onscreen help, the Help menu should be the
rightmost menu of your application’s menus. The first item is the name of the
application and the word “Help” (Mail Help, for example). This item should open
Help Viewer to the first page of your help content."

On the other hand, the window that opens is labelled "Mozilla Firefox Help".

Comment 2

[Asaf Romano (gone)]

What i'm going to fix here is the help document (menu reference) which refers to
"Help Contents".

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[Steffen Wilberg]

Comment on attachment 195292 [details] [diff] [review]
patch

r=me.

Comment 5

[Steffen Wilberg]

We're trying to keep branch and trunk version of help docs as much in sync as
possible, so I'd prefer if you could check this into both places once you've got
branch approval.

Comment 6

[Asaf Romano (gone)]

1.8 Branch:
Checking in menu_reference.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml,v  <-- 
menu_reference.xhtml
new revision: 1.31.2.4; previous revision: 1.31.2.3
done

Trunk:
Checking in menu_reference.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml,v  <-- 
menu_reference.xhtml
new revision: 1.35; previous revision: 1.34
done

Comment 7

[Ronny Perinke]

the patch didn't update firebird-toc.rdf (help toc)

"Help Contents" is still used for all platforms.

Comment 8

[Ronny Perinke]

Attachment: follow-up patch to update firebird-toc.rdf

Comment 9

[Steffen Wilberg]

Comment on attachment 200994 [details] [diff] [review]
follow-up patch to update firebird-toc.rdf

r=me.

Comment 10

[Marcia Knous [:marcia]]

Today's build - Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051031 Firefox/1.5 still shows "Firefox Help" as the menu item.

Today's trunk build looks okay, shows "Deer Park Help" as the menu item.

Comment 11

[Asaf Romano (gone)]

Marcia, that's the expected behavior (The bug here was/is about the menu reference).

Comment 12

[Asa Dotzler [:asa]]

moving out to the ride-along list if we need to do an RC2

Comment 13

[Steffen Wilberg]

Comment on attachment 200994 [details] [diff] [review]
follow-up patch to update firebird-toc.rdf

Checked into trunk and branch.