307462 - Link to release notes from about: points to 1.0 notes instead of 1.4 notes

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tom Hessman]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4

If you go to about: and click the "Firefox 1.4" link, it brings you to the
Firefox 1.0 release notes instead of the 1.4 releases notes.  Clicking "Release
Notes" in the Help menu does go to the correct place, however.

Reproducible: Always

Steps to Reproduce:
1. Go to the URL "about:"
2. Click the big blue link that says "Firefox 1.4"

Actual Results:  
It opened the Firefox 1.0 release notes
(http://www.mozilla.org/products/firefox/releases/1.0.html).

Expected Results:  
It should have opened the Firefox 1.4 release notes, like the Help menu does
(http://www.mozilla.org/products/firefox/releases/1.4.html).

Since about: uses the entity "&releaseURL;", anything else that uses it (if
anything else does) is affected as well.

Comment 1

[Jesse Ruderman]

Confirmed on Windows.

Comment 2

[Asa Dotzler [:asa]]

Rafael, can you look into getting this redirected on the server side to the
correct page?

Comment 3

[Asa Dotzler [:asa]]

Raf's taking this and we do need it for the beta. 

Comment 4

[Tom Hessman]

The current solution is not exactly ideal...it redirects anyone using Firefox
1.4 who tries to view the 1.0 release notes to the "Firefox 1.5 Beta 1 Start
Page" (http://www.mozilla.org/products/firefox/beta1.html).  First of all, it
should redirect to the release notes
(http://www.mozilla.org/products/firefox/releases/1.5beta1.html).  Secondly,
it's not a very good solution to redirect ALL users who go to the 1.0 notes with
Firefox 1.4 to the 1.4 notes...what if they were trying to view the 1.0 notes? 
While I understand that the release is imminent, and that there are already
candidate builds, I don't think that changing the value of &releaseURL is a very
risky change...

Comment 5

[Rubén Martín [:Nukeador] ❌ [away till Aug 31st]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.8b4) Gecko/20050908 Firefox/1.4

The link point to http://www.mozilla.org/products/firefox/releases/1.0.html
but it loads http://www.mozilla.org/products/firefox/releases/1.5beta1.html

Comment 6

[Rafael Ebron (:rebron)]

This was "fixed" on the server-side.  We need the right fix on the client side
in about.xhtml.  That releaseURL isn't working right.

over to bsmedberg?
maybe henrik can take this one.

Comment 7

[Benjamin Smedberg]

Attachment: Change release URL to 1.5

Comment 8

[Scott MacGregor]

Comment on attachment 198020 [details] [diff] [review]
Change release URL to 1.5

I can review this one :)

approving for the branch too.

Comment 9

[Steffen Wilberg]

Help->Release Notes links to "x.x.x.html", i.e. 1.4.1.html currently:
http://lxr.mozilla.org/mozilla1.8/source/browser/base/content/utilityOverlay.js#443

Why don't we do something similar here, e.g. specify the releaseURL entity as
"http://www.mozilla.org/products/firefox/releases/" and change the link in
about.xhtml to href="&releaseURL;__MOZ_APP_VERSION__.html"?

Comment 10

[Benjamin Smedberg]

Fixed on branch, which is the only place this matters. Steffen, I would love a
long-term solution that was better (and avoided putting version numbers in
locale packs), but in the interest of expediency this is all I want to do on the
branch. I'd love another bug with a nice patch on trunk.

Comment 11

[Jo Hermans]

*** Bug 268627 has been marked as a duplicate of this bug. ***

Comment 12

[Steffen Wilberg]

Trunk patch is in bug 318991.