The default bug view has changed. See this FAQ.

jsopcode.c doesn't build w/ !JS_HAS_XML_SUPPORT

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({fixed1.8})

Trunk
x86
Windows XP
fixed1.8
Points:
---
Bug Flags:
blocking1.8b5 +
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.59 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
jsopcode.c(941) : error C2065: 'inXML' : undeclared identifier
jsopcode.c(2062) : error C2065: 'inXML' : undeclared identifier
(Assignee)

Comment 1

12 years ago
Created attachment 195241 [details] [diff] [review]
option 1
(Assignee)

Comment 2

12 years ago
Created attachment 195242 [details] [diff] [review]
option 2
(Assignee)

Updated

12 years ago
Attachment #195241 - Flags: review?(brendan)
Comment on attachment 195241 [details] [diff] [review]
option 1

Nice minimal patch.

Nit: move that #undef up, the other local macros use FIFO, not LIFO, order of
#undef with respect to #define.

Thanks, this should go into the 1.8 branch when it opens after beta1 is tagged.

/be
Attachment #195241 - Flags: review?(brendan)
Attachment #195241 - Flags: review+
Attachment #195241 - Flags: approval1.8b5+
(Assignee)

Comment 4

12 years ago
Comment on attachment 195241 [details] [diff] [review]
option 1

mozilla/js/src/jsopcode.c	3.92
mozilla/js/src/jsopcode.c	3.89.2.3
Attachment #195241 - Attachment is obsolete: true
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You gonna hit the branch, too?

/be
Flags: blocking1.8b5+

Comment 6

12 years ago
seems this did land on the branch. please add the fixed1.8 keyword when you land
things on the branch. thanks.
Keywords: fixed1.8

Updated

12 years ago
Flags: testcase-
You need to log in before you can comment on or make changes to this bug.