Last Comment Bug 307469 - jsopcode.c doesn't build w/ !JS_HAS_XML_SUPPORT
: jsopcode.c doesn't build w/ !JS_HAS_XML_SUPPORT
Status: RESOLVED FIXED
: fixed1.8
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86 Windows XP
: -- normal (vote)
: ---
Assigned To: timeless
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-08 01:17 PDT by timeless
Modified: 2005-10-08 23:12 PDT (History)
2 users (show)
brendan: blocking1.8b5+
bob: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
option 1 (665 bytes, patch)
2005-09-08 01:18 PDT, timeless
brendan: review+
brendan: approval1.8b5+
Details | Diff | Splinter Review
option 2 (1.59 KB, patch)
2005-09-08 01:22 PDT, timeless
no flags Details | Diff | Splinter Review

Description timeless 2005-09-08 01:17:37 PDT
jsopcode.c(941) : error C2065: 'inXML' : undeclared identifier
jsopcode.c(2062) : error C2065: 'inXML' : undeclared identifier
Comment 1 timeless 2005-09-08 01:18:41 PDT
Created attachment 195241 [details] [diff] [review]
option 1
Comment 2 timeless 2005-09-08 01:22:20 PDT
Created attachment 195242 [details] [diff] [review]
option 2
Comment 3 Brendan Eich [:brendan] 2005-09-08 10:59:14 PDT
Comment on attachment 195241 [details] [diff] [review]
option 1

Nice minimal patch.

Nit: move that #undef up, the other local macros use FIFO, not LIFO, order of
#undef with respect to #define.

Thanks, this should go into the 1.8 branch when it opens after beta1 is tagged.

/be
Comment 4 timeless 2005-09-14 11:26:04 PDT
Comment on attachment 195241 [details] [diff] [review]
option 1

mozilla/js/src/jsopcode.c	3.92
mozilla/js/src/jsopcode.c	3.89.2.3
Comment 5 Brendan Eich [:brendan] 2005-09-14 11:55:37 PDT
You gonna hit the branch, too?

/be
Comment 6 Asa Dotzler [:asa] 2005-09-16 12:19:13 PDT
seems this did land on the branch. please add the fixed1.8 keyword when you land
things on the branch. thanks.

Note You need to log in before you can comment on or make changes to this bug.