Closed
Bug 307492
Opened 19 years ago
Closed 19 years ago
64-bit unsafe cast in TestIOThreads.cpp
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: benjamin, Assigned: benjamin)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
805 bytes,
patch
|
darin.moz
:
review+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
There is a 64-bit unsafe cast from void* -> int in TestIOThreads.cpp causing my build to fail on x86_64 gcc 4.0.1
|
||
Comment 2•19 years ago
|
||
Comment on attachment 195256 [details] [diff] [review] Use NS_PTR_TO_INT32, rev. 1 why not %p and avoid the dataloss?
Attachment #195256 -
Flags: review?(darin) → review-
|
Assignee | |
Comment 3•19 years ago
|
||
Comment on attachment 195256 [details] [diff] [review] Use NS_PTR_TO_INT32, rev. 1 Because it's not: http://lxr.mozilla.org/mozilla/source/netwerk/test/TestIOThreads.cpp#72
Attachment #195256 -
Flags: review- → review?(darin)
|
||
Updated•19 years ago
|
Attachment #195256 -
Flags: review?(darin) → review+
|
|
Assignee | |
Comment 5•19 years ago
|
||
Fixed on trunk for 1.9a. I'd like to get this on branch also.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Updated•19 years ago
|
Attachment #195256 -
Flags: approval1.8b5?
|
||
Updated•19 years ago
|
Attachment #195256 -
Flags: approval1.8b5? → approval1.8b5+
You need to log in
before you can comment on or make changes to this bug.
Description
•