307504 - numerous bugs dealing with padding

Status: VERIFIED INVALID

(Firefox :: General, defect)

Description

[u88484]

I really am not sure if all of these bugs were introduced by the patch for Bug#
303806 but at least a few were.

Please see screenshot for examples and here is my attempt to explain fully.

Bug# 1, not a bug...didn't feel liek editing the picture again
Bug# 2, In tools->options->downloads->browse, text is not vertically centerd in
the 'Folder: input box'
Bug# 2, in the picture I zoomed in to show this one and is kinda hard for me to
explain and everyone understand. type the letter 'L' in an input box, highlight
that letter, the highlight is right against the left side of the L and there
fore blends into the white background of the input boxes.
Bug# 4, tools->options->downloads->browse, icon for desktop is right against the
border for the box. same as with in the bookmarks manager
Bug# 5,Bookmarks manager->move, first '-'icon is too far left so there is no
paddiding between the icon and the focus ring. probably falls in with bug# 4.

Comment 1

[u88484]

Attachment: screenshot of the bugs

Comment 2

[James Ross]

Since you're using the native Windows directory picker, what you call bugs 2, 3
and 4 nothing to do with Firefox.

On my Windows 2000 and XP (Classic) systems, bug 1 has always existed and it
probably desired behaviour (the thing is not editable, after all).

Bug 5, those butt-ugly borders, I have no idea about. I'd like a little chat
with whoever approved that change, though, as they are crap.

Comment 3

[James Ross]

Also, FWIW, not a single one of these 'bugs' is from bug 303806 as far as I
know. The only real bug is the last one, and those crappy tree focus borders
have been around longer than the screwed-up menu appearance caused by bug 303806. :)

Comment 4

[u88484]

you say because using windows file picker, well how come IE got it perfect? and
the text is vertically centerd.

http://www.supernova00.biz/images/comparison.bmp sorry away from computer that
can save as jpg or png

Comment 5

[u88484]

Updating title because I went back and foudn otu these actually are not caused
by patch for Bug# 303806...but nonetheless they are still bugs.

Comment 6

[James Ross]

Your image is of the File Save dialog, not the Directory Chooser.

Comment 7

[Mike Connor [:mconnor]]

#1 is INVALID, its a read-only field.
#2,3,4 as Silver pointed out, are native filepicker issues that we're not stylingi
#5 Is already filed, we're trying to figure out a "better" solution to focus
rings being hard to see.