307526 - should be possible to use xpcshell from cygwin apps, including cygwin xemacs

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: add -t switch to xpcshell

The problem here is that isatty() returns no when handed a cygwin pipe.  This
patch adds a -t switch.  This switch behaves identically to -f, except that
isatty() is assumed to be true for any files specified this way.  So now
specifying "-f file1 -f file2 -t -" allows for mixed constructs.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: alternative: use - instead of -t

Dan, this is closer to what I was talking about. I think that - should just
signal us to force tty.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 195287 [details] [diff] [review]
add -t switch to xpcshell

Blake is consing up a new patch.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: use -i to force tty

Try this one on for size.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: -i patch, v2

This seems to make "xpcshell -i" work correctly.  I haven't tested without the
-i.  JS shell may need an analogous fix.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 195828 [details] [diff] [review]
-i patch, v2

If you pass a filename and -i it looks like we'll leak the file that we open. Altnernative in a bit.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Don't allow -i script.js

This simply disallows using -i and a filename. Easier on all.

Also the #if 0 stuff is wrong in the oom case, so we should remove it.

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 202575 [details] [diff] [review]
Don't allow -i script.js

>+        case 'i':
>+            forceTTY = JS_TRUE;
>+            isInteractive = JS_TRUE;

Chain these assignments, and sr=me contingent on dmose's r+.

/be

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 202575 [details] [diff] [review]
Don't allow -i script.js

r=dmose

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.