307559 - Update of Extensions (that are not compatible) after the installing of Firefox don't work

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[François Gagné]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4

Update of Extensions (that are not compatible) after the installing of Firefox
don't work properly, they are listed in Tools->Extentions but are simply not
working (and are not stated as imcompatible)

Reproducible: Always

Steps to Reproduce:
1) I install the Beta (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050907 Firefox/1.4)
2) A dialog pop and say that my 4 extensions are not compatible with the current
version:
 - Stumble Upon 2.0.3
 - FlashGot (some old version of it)
 - Tabbrowser Prefenreces 1.2.7.1
 - Adblock Plus 0.5.9 
3) I click the button on the bottom to check for updates 
4) It find 2 updates and install them:
 - FlashGot 0.5.9.91
 - Adblock Plus 0.5.9.2 
5) I restart Firefox for the new extensions to be installed. 
6) After restart the 2 extentions (FlashGot and Adblock Plus) are not working
even if they should.



Here is how to make them works:

1) Go in Tools->Extensions and click the "Find Updates" button. The versions of
FlashGot and Adblock Plus won't change but now they seems to be willing to run. 
2) Restart Firefox and now the 2 extentions should work.

Here is a way to check this:
1) Run a old version of Deer Park and install Adblock Plus 0.5.9
2) Restart Deer Park so the extension finish is installation
3) Install Firefox 1.5 Beta 1
4) Go though the Steps to Reproduce above.

Comment 1

[Benjamin Smedberg]

I think I know what's happening here: the infinite-restart-protection code is
kicking in, even though after app-update we really ought to reset it. Patch in 2
secs.

Comment 2

[Benjamin Smedberg]

Attachment: Reset the infinite-restart marker, rev. 1

Comment 3

[Darin Fisher]

Comment on attachment 195314 [details] [diff] [review]
Reset the infinite-restart marker, rev. 1

Yup, this great to me.	r=darin

Comment 4

[Scott MacGregor]

this patch effects the updater application that runs when applying software updates.

What we're seeing is more general. Run 1.0.6. Install some extensions. Now
install 1.5 beta 1 (not using software update). If your lucky enough to get the
extension update wizard, it will say it's downloading extension updates but none
of them actually get applied (even if you restart). You have to manually update
each one again in the extension manager for them to actually take effect.

This patch may fix a problem but it's not going to fix the problem reported here
which we're all seeing in the office. 

Comment 5

[Benjamin Smedberg]

Landed on trunk.

Comment 6

[François Gagné]

Not working with (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050909 Firefox/1.4), the patch should have landed.

Ok, some more testing, Adblock Plus 0.5.9.2 IS listed as incompatible after the
update, click "Find Updates" in Tools->Extensions still solve the problem.

Comment 7

[François Gagné]

Sorry, on your comment #5 you said on trunk, I was thinking about the 1.8 branch.

Comment 8

[François Gagné]

Ok tested with Trunk (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1)
Gecko/20050910 Firefox/1.6a1) it doesn't work.

In Tools->Extensions, Adblock Plus 0.5.9.2 is listed as not compatible, a simple
"Find Updates" (which change the status of Adblock Plus to update as been found
please restart), firefox restart and Adblock Plus works.

It seems that the wrong status is giving to extensions updated when you first
start Firefox.

Comment 9

[Asa Dotzler [:asa]]

Sounds like this doesn't solve the problem. 

Comment 10

[Benjamin Smedberg]

Checked in attachment 195314 [details] [diff] [review] on 1.8 branch. Leaving open for investigation of
the non-update case.

Comment 11

[Benjamin Smedberg]

Rob, can you take a look at the non-update case here? If not, bump it back to
darin or mconnor; I'm going to be on vacation next week and won't have a chance
to get to this before then.

Comment 12

[Robert Strong (they/them - no direct email)]

Not a problem.

François - do you by chance have steps to reproduce with a build that has this
patch? Thanks.

Comment 13

[François Gagné]

Ok I retested with trunk (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.9a1) Gecko/20050914 Firefox/1.6a1) using comment #1 and it still bug.

I'll try to make it as clear as possible how to do it (taken from comment #1)

NB: Adblock Plus 0.5.9
(http://bene.sitesled.com/installs/Adblock_Plus_0.5.9.xpi) in the following
intructions is a extension not compatible with Firefox > 1.0.x, Adblock Plus
0.5.9.2 is compatible with Firefox up to 1.6a1

1) Run a old version of Deer Park (or firefox 1.0.x) and install Adblock Plus 0.5.9
2) Restart Deer Park (or firefox 1.0.x) so the extension finish is installation
3) Install Firefox 1.5 Beta 1 (or Dear Park Trunk)
4) Start Firefox 1.5 Beta 1 (or Dear Park Trunk)
5) A dialog pop and say that Adblock Plus 0.5.9 is not compatible with the
current version of Firefox
6) Click the button on the bottom to check for updates ("Check now")
7) It will find a update for Adblock Plus 0.5.9 which is Adblock Plus 0.5.9.2
and it will install it 
8) Restart Firefox for Adblock Plus 0.5.9.2 to be installed. 
9) After restart, Adblock Plus 0.5.9.2 is not working even if it should.

Here is how to make Adblock Plus 0.5.9.2 works after the above instructions:

1) Go in Tools->Extensions and click the "Find Updates" button. The versions of
Adblock Plus 0.5.9.2 will stay the same but it now state that Firefox must be
restarted to make it works
2) Restart Firefox and now Adblock Plus 0.5.9.2 works.

(I'll test later with 1.8 branch)

Comment 14

[François Gagné]

ok tested with Firefox 1.8 branch (14-Sep-2005 11:25), the patch should have
landed and it still don't works.

Comment 15

[Robert Strong (they/them - no direct email)]

Thanks for the detailed instruction... I can reproduce this and will take a look
at what's going on.

Comment 16

[Worcester12345]

Though not necessarily related in the code, this seems awfully close to Bugzilla
Bug 294644 Incompatible extensions/themes cannot be installed disabled. Maybe
there is something in common to fix both with one whack. Thanks Robert Strong
for your work on these.

Comment 17

[Robert Strong (they/them - no direct email)]

That bug is an enhancement request and has absolutely nothing to do with this
bug. I also keep track of all of the extension manager bugs so there is no need
for you to provide this type of info for me in the future. Thanks.

Comment 18

[Robert Strong (they/them - no direct email)]

Attachment: patch - finish the operation

Darin - requesting review from you since I believe Benjamin is on vacation.

I considered just replacing this._updateManifests(true) further down with
this._finishOperations() but I'm not entirely comfortable with the possibility
of it not creating the .autoreg file so instead I took this approach which is
safer for 1.5 IMO.

BTW: there is another bug this uncovered in that what was happening here was
the extension was never upgraded but appeared to have been. This is due to the
item's metadata being updated well before the operations on the item have been
finished. I'll take care of that in a new bug.

Comment 19

[Robert Strong (they/them - no direct email)]

Filed bug 308638 for the issue with the metadata.

Comment 20

[Robert Strong (they/them - no direct email)]

Fixed on trunk

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.154; previous revision: 1.153

Comment 21

[Robert Strong (they/them - no direct email)]

Checked in on MOZILLA_1_8_BRANCH

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.144.2.9; previous revision: 1.144.2.8

Comment 22

[François Gagné]

Tested on Trunk and work fine :D