Calendar.jar contains a lot of files, that aren't used by Sunbird and should therefore by removed from it, mostly by using #ifndef MOZ_SUNBIRD. This would reduce the filesize of calendar.jar by 131kb and reduce the download size of the zip package by 72kb. The relevant files are: (Classic theme) - sunbird_small.png - btn1.png - calendar16.gif - taskbar-cal.gif - taskbar-cal-act.gif - taskbar-calalarm.gif - taskbar-calalarm-act.gif - Throbber-small.gif (is available via in mozilla/toolkit) - Throbber-small.png (is available via in mozilla/toolkit) (Modern theme) all of it. Patch coming soon to a bugzilla near you...
prefBird.xul and prefBirdOverlay.xul are also extension-only.
Created attachment 195561 [details] [diff] [review] patch v1
I'm going to delay this until after the next release.
Created attachment 207025 [details] [diff] [review] Patch v2 New patch after the new view landing
Comment on attachment 207025 [details] [diff] [review] Patch v2 I found an error in this patch.
Created attachment 207097 [details] [diff] [review] Patch v3
Created attachment 207308 [details] [diff] [review] Patch v4 I found some more stuff which can be left out. Since this patch looks a little bit more complicated than it really is, here's a short overview: - Removes modern theme from Sunbird - Removes the following extension-only files from Sunbird - about.html - about.xul - sunbird_small.png - menuOverlay.xul - calExtOverlay.js - calExtOverlay.xul - calendarMail.js - prefBird.xul - prefBirdOverlay.xul - btn1.png - calendar-16.gif - taskbar-cal.gif - taskbar-cal-act.gif - taskbar-calalarm.gif - taskbar-calalarm-act.gif - btn1.png - Uses the identical small throbber images from toolkit
Can you create a new patch that doesn't move the lines around? (like the locale files) It makes the patch hard to read.
Created attachment 207838 [details] [diff] [review] Alternative patch (for better readability) As requested here's an alternative patch, which doesn't move the lines around. This should improve patch readability. In case of a positive review, I would suggest to checkin the v4 patch, because all of the #ifdefs in the file look pretty ugly and make the code itself hard to read.
Created attachment 207839 [details] [diff] [review] Patch v5 jar.mn with four #ifdef/#ifndef blocks as requested by mvl on IRC.
Comment on attachment 207839 [details] [diff] [review] Patch v5 looks good, but it will conflict with the patch from bug 281935, so we need to fix that first.
Created attachment 208559 [details] [diff] [review] Patch v6 Patch updated to tip.
Comment on attachment 208559 [details] [diff] [review] Patch v6 looks good. r=mvl
patch checked in
This reduced the windows ZIP package by 77K :-)) It also caused bug 323665 :-((
mvl, if you find the time, can you please cvs remove the two obsolete files: - Throbber-small.png - Throbber-small.gif in calendar/sunbird/themes/winstripe/sunbird. Those files were removed from jar.mn and calendar.css in the v6 patch.
Those files have now been removed from cvs.