Closed Bug 307685 Opened 15 years ago Closed 14 years ago

Trim down calendar.jar for Sunbird

Categories

(Calendar :: Sunbird Only, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sipaq, Assigned: sipaq)

Details

Attachments

(1 file, 6 obsolete files)

Calendar.jar contains a lot of files, that aren't used by Sunbird and should
therefore by removed from it, mostly by using #ifndef MOZ_SUNBIRD.

This would reduce the filesize of calendar.jar by 131kb and reduce the download
size of the zip package by 72kb.

The relevant files are:

(Classic theme)
- sunbird_small.png
- btn1.png
- calendar16.gif
- taskbar-cal.gif
- taskbar-cal-act.gif
- taskbar-calalarm.gif
- taskbar-calalarm-act.gif
- Throbber-small.gif (is available via in mozilla/toolkit)
- Throbber-small.png (is available via in mozilla/toolkit)

(Modern theme)
all of it.

Patch coming soon to a bugzilla near you...
prefBird.xul and prefBirdOverlay.xul are also extension-only.
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #195561 - Flags: first-review?(mvl)
I'm going to delay this until after the next release.
Attached patch Patch v2 (obsolete) — Splinter Review
New patch after the new view landing
Attachment #195561 - Attachment is obsolete: true
Attachment #207025 - Flags: first-review?(mvl)
Attachment #195561 - Flags: first-review?(mvl)
Comment on attachment 207025 [details] [diff] [review]
Patch v2

I found an error in this patch.
Attachment #207025 - Attachment is obsolete: true
Attachment #207025 - Flags: first-review?(mvl)
Attached patch Patch v3 (obsolete) — Splinter Review
Attachment #207097 - Flags: first-review?(mvl)
Attached patch Patch v4 (obsolete) — Splinter Review
I found some more stuff which can be left out.
Since this patch looks a little bit more complicated than it really is, here's a short overview:

- Removes modern theme from Sunbird
- Removes the following extension-only files from Sunbird
  - about.html
  - about.xul
  - sunbird_small.png
  - menuOverlay.xul
  - calExtOverlay.js
  - calExtOverlay.xul
  - calendarMail.js
  - prefBird.xul
  - prefBirdOverlay.xul
  - btn1.png
  - calendar-16.gif
  - taskbar-cal.gif
  - taskbar-cal-act.gif
  - taskbar-calalarm.gif
  - taskbar-calalarm-act.gif
  - btn1.png
- Uses the identical small throbber images from toolkit
Attachment #207097 - Attachment is obsolete: true
Attachment #207308 - Flags: first-review?(mvl)
Attachment #207097 - Flags: first-review?(mvl)
Can you create a new patch that doesn't move the lines around? (like the locale files) It makes the patch hard to read.
As requested here's an alternative patch, which doesn't move the lines around. This should improve patch readability.

In case of a positive review, I would suggest to checkin the v4 patch, because all of the #ifdefs in the file look pretty ugly and make the code itself hard to read.
Attachment #207838 - Flags: first-review?(mvl)
Attached patch Patch v5 (obsolete) — Splinter Review
jar.mn with four #ifdef/#ifndef blocks as requested by mvl on IRC.
Attachment #207308 - Attachment is obsolete: true
Attachment #207838 - Attachment is obsolete: true
Attachment #207839 - Flags: first-review?(mvl)
Attachment #207308 - Flags: first-review?(mvl)
Attachment #207838 - Flags: first-review?(mvl)
Comment on attachment 207839 [details] [diff] [review]
Patch v5

looks good, but it will conflict with the patch from bug 281935, so we need to fix that first.
Attachment #207839 - Flags: first-review?(mvl)
Attached patch Patch v6Splinter Review
Patch updated to tip.
Attachment #207839 - Attachment is obsolete: true
Attachment #208559 - Flags: first-review?(mvl)
Comment on attachment 208559 [details] [diff] [review]
Patch v6

looks good.
r=mvl
Attachment #208559 - Flags: first-review?(mvl) → first-review+
patch checked in
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This reduced the windows ZIP package by 77K :-))

It also caused bug 323665 :-((
mvl, if you find the time, can you please cvs remove the two obsolete files:

- Throbber-small.png
- Throbber-small.gif

in calendar/sunbird/themes/winstripe/sunbird. Those files were removed from jar.mn and calendar.css in the v6 patch.
Those files have now been removed from cvs.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.