Closed Bug 307712 Opened 19 years ago Closed 12 years ago

There is no JS_CompileFileForPrincipals

Categories

(Core :: JavaScript Engine, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Future

People

(Reporter: timeless, Assigned: timeless)

References

()

Details

(Whiteboard: [timeless: need new patch])

Attachments

(1 obsolete file)

unfortunately FILE* pointers are not portable across modules (dll), if I build 
my js consumer using a different compiler (which i should be able to do), i'm 
only able to use JS_CompileFile which doesn't give me principals (which i need).

If you're ok w/ changing the behavior, JS_CompileFileHandleForPrincipals could 
be changed to accept a null handle and just use the filename. Alternatively a 
new JS_CompileFileForPrincipals could be added.
Attachment #195412 - Flags: review?(brendan)
Comment on attachment 195412 [details] [diff] [review]
change JS_CompileFileHandleForPrincipals to accept a null file

I'm ok with this, it seems like a compatible extension -- but only if you
update the devmo-hosted JS API docs!

/be
Attachment #195412 - Flags: review?(brendan) → review+
Flags: testcase-
Assignee: general → timeless
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 195412 [details] [diff] [review]
change JS_CompileFileHandleForPrincipals to accept a null file

JS_CompileFileHandleForPrincipals has changed significantly since this bug was posted. This patch is bitrotted.
Attachment #195412 - Attachment is obsolete: true
Whiteboard: [timeless: need new patch]
Target Milestone: mozilla1.9alpha1 → Future
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: