307743 - Bookmark export discards keywords (shortcut URLs)

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Chris Lawson (gone)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050909 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050909 Camino/1.0+

When bookmarks are exported, the keyword (shortcut URL) is discarded.

Reproducible: Always

Steps to Reproduce:
1. Export bookmarks.
2. Note loss of shortcut URL/keyword.

Actual Results:  
Keywords were lost.

Expected Results:  
Keywords should be properly exported, as with Firefox.

Comment 1

[Chris Lawson (gone)]

Attachment: Patch to export keyword in bookmark export

This takes care of the keyword problem, and only the keyword problem. See bug
307620 for the rest of the issues to make Camino's bookmarks export match that
of Firefox.

Comment 2

[Mike Pinkerton (not reading bugmail)]

what happens if there's no keyword? we really shouldn't add 8 characters to
every single bookmark that's exported when there isn't one, right? does firefox
expect that?

Comment 3

[Chris Lawson (gone)]

Firefox doesn't appear to have any problems importing our bookmarks as they are,
so I'll revise the patch not to append the "SHORTCUTURL" bit if there isn't one.

Feel free to assign this to me, BTW.

cl

Comment 4

[Chris Lawson (gone)]

Comment on attachment 195435 [details] [diff] [review]
Patch to export keyword in bookmark export

Obsoleting.

Comment 5

[Chris Lawson (gone)]

Attachment: New patch incorporating Pink's suggestion that we only add the attribute when it's there

Note: this patch also includes the fix for bug 304118.

cl

Comment 6

[Chris Lawson (gone)]

Attachment: New revision, incorporating smorgan's suggestions

OK, this one again fixes both bugs, and this one adds support for the
LAST_VISIT attribute as well. I think it's ready for review at this point.

cl

Comment 7

[Samuel Sidler (old account; do not CC)]

Wevah: Care to do a quick review before sr?

Comment 8

[Chris Lawson (gone)]

Attachment: new patch, using more efficient stringByAppendingFormat method

Comment 9

[Chris Lawson (gone)]

Attachment: revision 3

Fixes a minor style error in the file and uses padString instead of a
hard-coded set of spaces for exporting menu spacers.

cl

Comment 10

[Simon Fraser [no longer active]]

Patch landed. Thanks!