Bookmark export discards keywords (shortcut URLs)

RESOLVED FIXED in Camino1.0

Status

RESOLVED FIXED
14 years ago
8 years ago

People

(Reporter: bugzilla-graveyard, Assigned: bugzilla-graveyard)

Tracking

(Blocks: 1 bug, {fixed1.8})

unspecified
Camino1.0
PowerPC
macOS
fixed1.8
Dependency tree / graph

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050909 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050909 Camino/1.0+

When bookmarks are exported, the keyword (shortcut URL) is discarded.

Reproducible: Always

Steps to Reproduce:
1. Export bookmarks.
2. Note loss of shortcut URL/keyword.

Actual Results:  
Keywords were lost.

Expected Results:  
Keywords should be properly exported, as with Firefox.
(Assignee)

Comment 1

14 years ago
This takes care of the keyword problem, and only the keyword problem. See bug
307620 for the rest of the issues to make Camino's bookmarks export match that
of Firefox.
Attachment #195435 - Flags: review?
(Assignee)

Updated

14 years ago
Summary: Bookmarks export discards keywords → Bookmark export discards keywords (shortcut URLs)
Target Milestone: --- → Camino1.1
what happens if there's no keyword? we really shouldn't add 8 characters to
every single bookmark that's exported when there isn't one, right? does firefox
expect that?
Target Milestone: Camino1.1 → Camino1.0
(Assignee)

Comment 3

14 years ago
Firefox doesn't appear to have any problems importing our bookmarks as they are,
so I'll revise the patch not to append the "SHORTCUTURL" bit if there isn't one.

Feel free to assign this to me, BTW.

cl
Assignee: pinkerton → bugzilla
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 4

14 years ago
Comment on attachment 195435 [details] [diff] [review]
Patch to export keyword in bookmark export

Obsoleting.
Attachment #195435 - Attachment is obsolete: true
Attachment #195435 - Flags: review?
(Assignee)

Comment 5

14 years ago
Note: this patch also includes the fix for bug 304118.

cl
Attachment #195504 - Flags: review?
(Assignee)

Comment 6

14 years ago
OK, this one again fixes both bugs, and this one adds support for the
LAST_VISIT attribute as well. I think it's ready for review at this point.

cl
Attachment #195504 - Attachment is obsolete: true
Attachment #195578 - Flags: review?
(Assignee)

Updated

14 years ago
Attachment #195504 - Flags: review?
Wevah: Care to do a quick review before sr?
Blocks: 304118
(Assignee)

Comment 8

14 years ago
Attachment #195578 - Attachment is obsolete: true
Attachment #195968 - Flags: review?
(Assignee)

Updated

14 years ago
No longer blocks: 309008
(Assignee)

Updated

14 years ago
Attachment #195578 - Flags: review?
(Assignee)

Comment 9

14 years ago
Posted patch revision 3Splinter Review
Fixes a minor style error in the file and uses padString instead of a
hard-coded set of spaces for exporting menu spacers.

cl
Attachment #195968 - Attachment is obsolete: true
Attachment #196742 - Flags: review?
(Assignee)

Updated

14 years ago
Attachment #195968 - Flags: review?

Comment 10

14 years ago
Patch landed. Thanks!
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Updated

14 years ago
Attachment #196742 - Flags: review? → review+

Updated

14 years ago
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.