User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050909 Camino/1.0+ Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050909 Camino/1.0+ When bookmarks are exported, the keyword (shortcut URL) is discarded. Reproducible: Always Steps to Reproduce: 1. Export bookmarks. 2. Note loss of shortcut URL/keyword. Actual Results: Keywords were lost. Expected Results: Keywords should be properly exported, as with Firefox.
This takes care of the keyword problem, and only the keyword problem. See bug 307620 for the rest of the issues to make Camino's bookmarks export match that of Firefox.
Summary: Bookmarks export discards keywords → Bookmark export discards keywords (shortcut URLs)
what happens if there's no keyword? we really shouldn't add 8 characters to every single bookmark that's exported when there isn't one, right? does firefox expect that?
Target Milestone: Camino1.1 → Camino1.0
Firefox doesn't appear to have any problems importing our bookmarks as they are, so I'll revise the patch not to append the "SHORTCUTURL" bit if there isn't one. Feel free to assign this to me, BTW. cl
Assignee: pinkerton → bugzilla
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 195435 [details] [diff] [review] Patch to export keyword in bookmark export Obsoleting.
OK, this one again fixes both bugs, and this one adds support for the LAST_VISIT attribute as well. I think it's ready for review at this point. cl
Wevah: Care to do a quick review before sr?
Fixes a minor style error in the file and uses padString instead of a hard-coded set of spaces for exporting menu spacers. cl
Patch landed. Thanks!
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #196742 - Flags: review? → review+
You need to log in before you can comment on or make changes to this bug.