307796 - Middle-click on menubutton that closes a menupopup does not set _moz-menuactive="false"

Status: RESOLVED WORKSFORME

(Firefox :: Menus, defect)

Description

[Joshua Welderson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

Basically, since the totally lovely and uncontroversial patch for bug 303806
landed, menubuttons inside the menubar has attempted to be highlighted on
mouseover.  Unfortunately, if one middle-clicks on a menubutton inside a
menupopup, the background color remains, though the menupopup closes.

Reproducible: Always

Steps to Reproduce:
1. Middle click on Help --> Release Notes.
Actual Results:  
The 'Help' menubutton stayed highlighted, though the menupopup closed and the
page opened in a new tab.

Expected Results:  
The menubutton should have lost its highlight.

I suspect the issue is more that menupopups are not treating middle clicks as
changing a menu's "active" status; however, I do not recall this issue in the
previous version of the theme, so I think it's a regression.

This should probably block 1.5b2, as it's a significant polish issue and I don't
think the "make menus only compatible with Luna" patch is going to be backed out
any time soon.

Comment 1

[Ria Klaassen (not reading all bugmail)]

It has been like that long before the patch of bug 303806 landed. I found it in
a 16 June build. The difference is that before the patch the selection had
another color. See screenshot: http://img360.imageshack.us/img360/6043/menu2sy.png

Comment 2

[Joshua Welderson]

True.  Updating summary to reflect this.

Comment 3

[Martijn Wargers (dead)]

Attachment: patch

This fixes it for me.

Comment 4

[Martijn Wargers (dead)]

Is this still an issue? It seems like the problem has been solved somehow.

Comment 5

[François Gagné]

It seems to be fixed on 1.8.1 but it's not fixed on 1.5.0.3.

Comment 6

[Martijn Wargers (dead)]

Well, it's not going to get fixed on the 1.5.0.x branch (because it's not a security bug, or crash bug), so marking wfm then.

Comment 7

[Wayne Mery (:wsmwk)]

happens for me on current FF trunk