307820 - please back out extra padding due to bug 303806

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Aaron Slunt]

This isn't a request to back out the patch for 303806, but it is a request to
back out the extra padding that is now in menus.

The reason for this? Think of how lengthy the extra padding can make the
bookmarks menu: many users who could fit all their bookmarks onto the screen,
maybe having an extra 50px or so, will now have to scroll to see all of their
bookmarks.

The extra padding doesn't really help out here, especially in this case (which
common sense says would be quite common).

Just please back out the extra padding in menus.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Yep, I see two scroll arrows now in my bookmarks. Previously I had place for 35
items, now only for 31 items.

Comment 2

[Alfred Kayser]

Patch attached to bug 312527, so marking this one as 'dup' to that one...

*** This bug has been marked as a duplicate of 312527 ***

Comment 3

[Alfred Kayser]

Unduping from bug 312527, as that one will only solve the padding of the
bookmarks menu. 

The issue here is that the 'Wallpaper' patch introduced unneeded extra padding,
which in no other theme and/or system native rendering present. 
A patch to address the overall menu padding issue will be attached, and I will
persue to get it in 1.8 (using polite argumentation, some pleading, asking for
solid reviews, doing some solid testing, etc...).

Comment 4

[Alfred Kayser]

Attachment: Patch to fix the menu padding introduced by bug 303806 (the Wallpaper patch)

See the forum on this topic:
http://forums.mozillazine.org/viewtopic.php?t=315361&postdays=0&postorder=asc&postsperpage=15&highlight=menu+padding&start=375


This code has been tested there extensively!

Comment 5

[Alfred Kayser]

Politely asking to consider this for 1.8, ask this is a fix for menu padding
caused by the wallpaper patch (bug 303806). As this patch is about reversing
some minor styling changes in the theme .css files, the impact/risk is very very
small.

So, this is thus a very safe alternative to bug 243078, which caused all that
trouble, but which really tried to get the 'ugly' menu rendering caused by the
Wallpaper patch fixed. This patch only corrects some padding, and won't
introduce new (unwanted) effects!

Comment 6

[Scott MacGregor]

too late in the game for non critical changes anymore.

Comment 7

[Scott MacGregor]

this looks just like Bug 312527 to me.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 199904 [details] [diff] [review]
Patch to fix the menu padding introduced by bug 303806 (the Wallpaper patch)

not going to revert, decision is to keep the extra padding for
readability/mouse access.