307824 - [en] View > Sort By > "_Attachments" and "Sort _Ascending" share same keyboard access key (shortcut)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mikel Ward]

Under the main View->Sort By menu, both the Attachments and Ascending item share
the same keyboard access key, A.  Therefore, pressing Alt-V, S, A, is somewhat
ambiguous.

Comment 1

[Thomas D. (:thomas8)]

Blake, would you grant ui-r+ for unambiguating the shared access keys between Ascending and Attachments like this, per analysis below?

Proposal:

Attach_m_ent
_A_scending

I'd think that Sort By > Ascending is much more frequent/versatile (because it applies on top of any other sort criterion) and thus more important than Sort By > Attachment, so Ascending should keep the A as access key, and attachments should get another letter if possible.

Fyi Bug 797877 (and bug 699588) will touch these access keys as we correct and add some columns.

So let's check which access keys are available for attachment:

A -> in use for Ascending (which wins, this bug)
tt -> in use for threaded (which wins)
a -> Ascending (this bug)
c -> Recipients (currently, and still in bug 797877; otherwise would be taken for CC when we implement that column)
h -> Unthreaded (whose u is used for Status)
m -> ** available
e -> Date
n -> ** available
t -> threaded

Comment 2

[Jim Porter (:squib)]

dorsatum: I saw you asked about this on IRC, but left before I had a chance to reply. I'd start by looking around here: http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/chrome/messenger/messenger.dtd#174

Comment 3

[rsx11m]

(In reply to Thomas D. (away till 23rd Oct) from comment #1)
> Attach_m_ent
> _A_scending

That's what SeaMonkey has chosen for that (virtually identical) menu.

Comment 4

[Projjol [:dorsatum]]

Attachment: Patch: Fix issue of _Attachments and _Ascending sharing the same access key: Change access key for Attachments to m.

Comment 5

[Thomas D. (:thomas8)]

Comment on attachment 815323 [details] [diff] [review]
Patch: Fix issue of _Attachments and _Ascending sharing the same access key: Change access key for Attachments  to m.

Blake, a one-line patch for your ui-review, just correcting a duplicate access key:

In "View > Sort by >" menu, _Attchments and _Ascending currently share the same access key "A". This patch fixes that by changing the access key for "Attachments" to "m": Attach_ments.

> <!ENTITY sortAscending.accesskey "A">
>-<!ENTITY sortByAttachmentsCmd.accesskey "A">
>+<!ENTITY sortByAttachmentsCmd.accesskey "m">

"Ascending" should keep "A" access key because it is more frequently used than "Attachment". All other potential access keys contained in the word "Attachment" are already taken by other (more relevant) sort commands in the same menu, so the choice was really only between "m" and "n", as listed up in my comment 1 (1). Seamonkey also has "m" for Attach_ments on the same menu.

Tia.

(1) https://bugzilla.mozilla.org/show_bug.cgi?id=307824#c1

Comment 6

[rsx11m]

Looks good to me. I don't think this needs the entity name(s) to be changed, given that it's an en-US fix only to resolve an accesskey conflict, thus the patch should be fine as is.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 815323 [details] [diff] [review]
Patch: Fix issue of _Attachments and _Ascending sharing the same access key: Change access key for Attachments  to m.

ui-r=me, on the condition that Lightning doesn't already use the "m" shortcut for something…  (If it does, then I think we need to think about this a little more.)

Thanks,
Blake.

Comment 8

[Thomas D. (:thomas8)]

(In reply to Blake Winton (:bwinton) from comment #7)
> Comment on attachment 815323 [details] [diff] [review]
> ui-r=me, on the condition that Lightning doesn't already use the "m"
> shortcut for something…  (If it does, then I think we need to think about
> this a little more.)

Awesome! ;)  Lightning speed ui-review, otherwise no Lightning involved in this menu.

So now we just need Jim or anybody to r+ the one-liner before checkin... (nothing to review really, and already pre-reviewed+ by rsx11m in comment 6)

Comment 9

[Jim Porter (:squib)]

Comment on attachment 815323 [details] [diff] [review]
Patch: Fix issue of _Attachments and _Ascending sharing the same access key: Change access key for Attachments  to m.

Review of attachment 815323 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 10

[Thomas D. (:thomas8)]

(In reply to Jim Porter (:squib) from comment #9)
> Comment on attachment 815323 [details] [diff] [review]
> Review of attachment 815323 [details] [diff] [review]:
> rs=me

Awesome again!

Look forward to :RyanVM to land this on Trunk usually within a day or two after setting "checkin-needed" keyword...

probaner23, thanks for providing the patch! :)
There's more little things out there like this one which you could enjoy getting out of the way ;)
What about this one:

Bug 677276 - Numbering of access keys for attachments list in the menus should start at one, not zero

Comment 11

[Projjol [:dorsatum]]

> There's more little things out there like this one which you could enjoy
> getting out of the way ;)
> What about this one:
> 
> Bug 677276 - Numbering of access keys for attachments list in the menus
> should start at one, not zero

Thanks! And I'll get right onto 677276!

Comment 12

[Stuart Rogers]

Please see my comments on Bug 925774.  Could you use H consistently to access Attachments?  ('Sort by Unthreaded' could use U.)

Comment 13

[rsx11m]

This should be discussed in bug 925774 given that the immediate issue. Also, the 'u' accesskey is already in use for that menu, thus your suggestion on how to free up the 'h' key wouldn't work.

Comment 14

[rsx11m]

(In reply to rsx11m from comment #13)
> This should be discussed in bug 925774 given that the immediate issue

Oops, I meant to add "... of resolving the accesskey conflict has been resolved."

Comment 15

[Stuart Rogers]

I do discuss it in 925774, and cross-ref back to this bug, because co-ordination is required.  And this bug is till open ("assigned"), not resolved.

Yes, I missed the U in StatUs.  But I don't see N used anywhere, so uNthreaded could use N and AttacHments could use H.  (M is not the a good choice for consistency, because in the File menu the word is Attach, not Attachments.)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/6a3352c8d0bc